-
Notifications
You must be signed in to change notification settings - Fork 455
chore(llmobs): projects support for dne #14517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 273 ± 5 ms. The average import time from base is: 275 ± 5 ms. The import time difference between this PR and base is: -2.2 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsCandidate: gary/mlob-3858 (a5cac1d) 🔵 No Baseline Data (22 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
29882a6
to
177f6f7
Compare
177f6f7
to
075977c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just a couple of questions!
Update ddtrace/llmobs/_writer.py Co-authored-by: Sam Brenner <[email protected]> Update ddtrace/llmobs/_writer.py Co-authored-by: Sam Brenner <[email protected]> Update ddtrace/llmobs/_writer.py Co-authored-by: Sam Brenner <[email protected]> Update ddtrace/llmobs/_llmobs.py Co-authored-by: Sam Brenner <[email protected]>
48507c6
to
8689bff
Compare
08134ba
to
1db9df9
Compare
…l fail other tests
1db9df9
to
fcf1ee8
Compare
adds support for projects
LLMObs.enable
call or the env var is usedwith this snippet
we get the following output
the first pull hits an exception because the dataset wasn't found in the default project from the enable call, and the 2nd pull succeeds, all as expected
an alternate approach would be to initialize default project in
enable
, but that messes with the tests everywhere that don't have cassettesChecklist
Reviewer Checklist