Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): access lock acquired time only when the lock is held [backport 2.18] #11896

Closed
wants to merge 1 commit into from

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Jan 10, 2025

Manual backport of #11881 to 2.18

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim added the Profiling Continous Profling label Jan 10, 2025
@taegyunkim taegyunkim requested review from a team as code owners January 10, 2025 15:16
Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/profiling-lock-acquired-at-e308547cffdca9f7.yaml     @DataDog/apm-python
ddtrace/profiling/collector/_lock.py                                    @DataDog/profiling-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-11881-to-2.18
Commit report: f809e8b
Test service: dd-trace-py

✅ 0 Failed, 5 Passed, 1463 Skipped, 57.37s Total duration (35m 27.86s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks

Benchmark execution time: 2025-01-10 15:55:09

Comparing candidate commit f809e8b in PR branch backport-11881-to-2.18 with baseline commit 0a56ee9 in branch 2.18.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 334 metrics, 2 unstable metrics.

@taegyunkim taegyunkim closed this Jan 10, 2025
@taegyunkim taegyunkim deleted the backport-11881-to-2.18 branch January 10, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant