Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix flaky es search query [backport 2.19] #11879

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2025

Backport 6c61f40 from #11877 to 2.19.

It seems sometimes we don't have the index/mapping set up properly. I didn't try to dig into why since it shouldn't matter too much for this specific test case anyways.

The solution is in the query to specify the type of the name field if it is unmapped.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 8, 2025
@github-actions github-actions bot requested review from a team as code owners January 8, 2025 20:24
@taegyunkim taegyunkim closed this Jan 8, 2025
@taegyunkim taegyunkim reopened this Jan 8, 2025
Copy link
Contributor Author

github-actions bot commented Jan 8, 2025

CODEOWNERS have been resolved as:

tests/contrib/elasticsearch/test_elasticsearch.py                       @DataDog/apm-core-python @DataDog/apm-idm-python

@brettlangdon brettlangdon enabled auto-merge (squash) January 8, 2025 20:27
@pr-commenter
Copy link

pr-commenter bot commented Jan 8, 2025

Benchmarks

Benchmark execution time: 2025-01-08 21:05:04

Comparing candidate commit 608d6a3 in PR branch backport-11877-to-2.19 with baseline commit 2ba151b in branch 2.19.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 320 metrics, 2 unstable metrics.

@brettlangdon brettlangdon merged commit 3d0089c into 2.19 Jan 8, 2025
231 checks passed
@brettlangdon brettlangdon deleted the backport-11877-to-2.19 branch January 8, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants