Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(propagation): make baggage header extract case insensitive #11859

Merged
merged 10 commits into from
Jan 9, 2025

Conversation

ZStriker19
Copy link
Contributor

@ZStriker19 ZStriker19 commented Jan 6, 2025

Following the WSGI spec, headers shouldn't be case sensitive, therefore baggage, like the other headers we extract, should not be case sensitive.
https://peps.python.org/pep-3333/#environ-variables: "(A reminder for server/gateway authors: HTTP header names are case-insensitive, so be sure to take that into consideration when examining application-supplied headers!)"

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 6, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/case_insensitive_baggage_header_extraction-63167c492474da6f.yaml  @DataDog/apm-python
ddtrace/propagation/http.py                                             @DataDog/apm-sdk-api-python
tests/tracer/test_propagation.py                                        @DataDog/apm-sdk-api-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 6, 2025

Datadog Report

Branch report: zachg/make_baggage_extraction_wsgi_compliant
Commit report: 33a0176
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1378 Skipped, 3m 45.43s Total duration (35m 2.1s time saved)

@ZStriker19 ZStriker19 marked this pull request as ready for review January 6, 2025 19:31
@ZStriker19 ZStriker19 requested review from a team as code owners January 6, 2025 19:31
@pr-commenter
Copy link

pr-commenter bot commented Jan 6, 2025

Benchmarks

Benchmark execution time: 2025-01-09 15:35:51

Comparing candidate commit 33a0176 in PR branch zachg/make_baggage_extraction_wsgi_compliant with baseline commit 5581f73 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@ZStriker19 ZStriker19 merged commit 68fc8f0 into main Jan 9, 2025
576 checks passed
@ZStriker19 ZStriker19 deleted the zachg/make_baggage_extraction_wsgi_compliant branch January 9, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants