chore: avoids using deprecated modules in tests and log injection [3.0 prep] #11835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 27.99s Total duration (27m 41.67s time saved) |
BenchmarksBenchmark execution time: 2025-01-14 06:04:46 Comparing candidate commit c7cd2b7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
mabdinur
force-pushed
the
munir/make-integrations-even-more-internal
branch
from
d45e839 to
479646d
Compare
mabdinur
requested review from
rachelyangdog,
anmarchenko,
erikayasuda and
wantsui
mabdinur
changed the title
mabdinur
added
the
changelog/no-changelog
mabdinur
force-pushed
the
munir/make-integrations-even-more-internal
branch
from
330fd7a to
f1d4650
Compare
mabdinur
changed the title
emmettbutler
approved these changes
Jan 8, 2025
Co-authored-by: Emmett Butler <[email protected]>
2 tasks
Yun-Kim
approved these changes
Jan 13, 2025
…ns-even-more-internal
juan-fernandez
approved these changes
Jan 14, 2025
rachelyangdog
approved these changes
Jan 14, 2025
gnufede
approved these changes
Jan 14, 2025
mabdinur
added a commit
that referenced
this pull request
Jan 21, 2025
…all integrations [3.0] (#11916) Requires: [chore: avoids using deprecated modules in tests and log injection [3.0 prep]](#11835). Follow up to: #11918 This change internalizes the following functions: - `ddtrace.contrib.<integration_name>.patch()` - `ddtrace.contrib.<integration_name>.unpatch()` - `ddtrace.contrib.<integration_name>.get_version()` This change also internalizes all integrations that only expose `patch()`, `unpatch()`, and `get_version()` functions. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddtrace.contribare not used internally. The deprecated modules will be removed in v3.XChecklist
Reviewer Checklist