Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracing): move mini agent out of tracing #11814

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Dec 19, 2024

Description

No idea where we should put starting the mini-agent but doing it in tracer initialization feels wrong. The mini agent should only be started once (at most).

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/__init__.py                                                     @DataDog/apm-core-python
ddtrace/_trace/tracer.py                                                @DataDog/apm-sdk-api-python

@mabdinur mabdinur marked this pull request as ready for review December 19, 2024 23:14
@mabdinur mabdinur requested review from a team as code owners December 19, 2024 23:14
@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Benchmark execution time: 2024-12-20 19:19:52

Comparing candidate commit fdbbf46 in PR branch munir/move-mini-agent-start-from-trace-init with baseline commit 3d08709 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur requested a review from erikayasuda December 20, 2024 18:37
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: munir/move-mini-agent-start-from-trace-init
Commit report: fdbbf46
Test service: dd-trace-py

✅ 0 Failed, 98 Passed, 1370 Skipped, 1m 34.55s Total duration (34m 18.42s time saved)

Copy link
Contributor

@erikayasuda erikayasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a follow up convo with serverless, but for now LGTM!

@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants