Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): upgrade python for build action [backport 2.17] #11812

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Dec 19, 2024

Backport 073f7f5 from #11735 to 2.17.

python 3.7 is no longer supported on ubuntu.
This PR update the python version for the build action to 3.12

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

python 3.7 is no longer supported on ubuntu.
This PR update the python version for the build action to 3.12

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 073f7f5)
@erikayasuda erikayasuda requested review from a team as code owners December 19, 2024 22:43
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: 2.17
Commit report: 69cd420
Test service: dd-trace-py

✅ 0 Failed, 1286 Passed, 0 Skipped, 13m 12.43s Total Time

@erikayasuda erikayasuda requested a review from a team as a code owner December 19, 2024 22:44
@erikayasuda erikayasuda changed the base branch from main to 2.17 December 19, 2024 22:44
@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 19, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/build_deploy.yml                                      @DataDog/python-guild @DataDog/apm-core-python

@erikayasuda erikayasuda reopened this Dec 19, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Benchmark execution time: 2024-12-19 23:24:32

Comparing candidate commit 22e29e9 in PR branch backport-11735-to-2.17 with baseline commit 7a275e6 in branch 2.17.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

@taegyunkim taegyunkim merged commit 63cc224 into 2.17 Dec 20, 2024
323 of 324 checks passed
@taegyunkim taegyunkim deleted the backport-11735-to-2.17 branch December 20, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants