-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove time module functions from ddtrace.internal.compat #11799
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this, amazing!
BenchmarksBenchmark execution time: 2024-12-20 14:55:27 Comparing candidate commit 0f2e63a in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 392 metrics, 2 unstable metrics. scenario:iast_aspects-ospathbasename_aspect
scenario:iast_aspects-ospathsplitext_aspect
|
Datadog ReportBranch report: ✅ 0 Failed, 922 Passed, 546 Skipped, 18m 44.5s Total duration (19m 45.72s time saved) |
Looks like these functions were added to support Python < 3.7 and we no longer support those.
Checklist
Reviewer Checklist