Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove time module functions from ddtrace.internal.compat #11799

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Dec 19, 2024

Looks like these functions were added to support Python < 3.7 and we no longer support those.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim changed the title chore: remove time module functions from compat. chore: remove time module functions from compat Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

CODEOWNERS have been resolved as:

benchmarks/rate_limiter/scenario.py                                     @DataDog/apm-core-python
ddtrace/_trace/span.py                                                  @DataDog/apm-sdk-api-python
ddtrace/contrib/internal/botocore/services/kinesis.py                   @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/kafka/patch.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/debugging/_debugger.py                                          @DataDog/debugger-python
ddtrace/debugging/_origin/span.py                                       @DataDog/debugger-python
ddtrace/internal/compat.py                                              @DataDog/python-guild @DataDog/apm-core-python
ddtrace/internal/opentelemetry/span.py                                  @DataDog/apm-sdk-api-python
ddtrace/internal/rate_limiter.py                                        @DataDog/apm-core-python
ddtrace/internal/utils/time.py                                          @DataDog/apm-core-python
ddtrace/profiling/collector/_lock.py                                    @DataDog/profiling-python
ddtrace/profiling/collector/memalloc.py                                 @DataDog/profiling-python
ddtrace/profiling/collector/stack.pyx                                   @DataDog/profiling-python
ddtrace/profiling/scheduler.py                                          @DataDog/profiling-python
ddtrace/vendor/__init__.py                                              @DataDog/apm-core-python
tests/debugging/mocking.py                                              @DataDog/debugger-python
tests/integration/test_sampling.py                                      @DataDog/apm-core-python
tests/profiling/exporter/test_http.py                                   @DataDog/profiling-python
tests/profiling/test_accuracy.py                                        @DataDog/profiling-python
tests/profiling/test_scheduler.py                                       @DataDog/profiling-python
tests/submod/stuff.py                                                   @DataDog/apm-core-python
tests/tracer/test_rate_limiter.py                                       @DataDog/apm-sdk-api-python

@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 19, 2024
@taegyunkim taegyunkim changed the title chore: remove time module functions from compat chore: remove time module functions from ddtrace/internal/compat Dec 19, 2024
@taegyunkim taegyunkim changed the title chore: remove time module functions from ddtrace/internal/compat chore: remove time module functions from ddtrace.internal.compat Dec 19, 2024
@taegyunkim taegyunkim marked this pull request as ready for review December 19, 2024 19:41
@taegyunkim taegyunkim requested review from a team as code owners December 19, 2024 19:41
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this, amazing!

@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Benchmark execution time: 2024-12-20 14:55:27

Comparing candidate commit 0f2e63a in PR branch taegyunkim/compat-time with baseline commit 20b2b03 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 392 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟥 execution_time [+411.023ns; +470.629ns] or [+12.552%; +14.372%]

scenario:iast_aspects-ospathsplitext_aspect

  • 🟥 execution_time [+361.036ns; +415.042ns] or [+10.001%; +11.497%]

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: taegyunkim/compat-time
Commit report: 0f2e63a
Test service: dd-trace-py

✅ 0 Failed, 922 Passed, 546 Skipped, 18m 44.5s Total duration (19m 45.72s time saved)

@taegyunkim taegyunkim merged commit 6ea56c5 into main Dec 20, 2024
689 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/compat-time branch December 20, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants