Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): remove DD_TRACE_ENABLED from configuration docs #11795

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Dec 19, 2024

These are defined in the corporate docs, so we should just keep them there as the source of truth. The link to the corporate docs has also been added here.

See generated docs for this branch here

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 19, 2024
@erikayasuda erikayasuda requested a review from a team as a code owner December 19, 2024 18:32
Copy link
Contributor

CODEOWNERS have been resolved as:

docs/configuration.rst                                                  @DataDog/python-guild

@erikayasuda erikayasuda enabled auto-merge (squash) December 19, 2024 18:59
@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Benchmark execution time: 2024-12-19 19:28:46

Comparing candidate commit c1ae8ea in PR branch erikayasuda/remove-dd-trace-enabled with baseline commit 315a48f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@erikayasuda erikayasuda merged commit 42f69dc into main Dec 20, 2024
214 of 216 checks passed
@erikayasuda erikayasuda deleted the erikayasuda/remove-dd-trace-enabled branch December 20, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants