Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracer): remove asm properties from the tracer class #11791

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Dec 19, 2024

Description

Removes and use asm_config instead:

  • Tracer._asm_enabled
  • Tracer._iast_enabled
  • Tracer._appsec_standalone_enabled

Next steps:

  • Remove all asm, profiling, and serverless specific logic from tracer.py.
    • Define a product level configure method
    • Introduce product level processors and move iast, asm, and profiling processors (or let @

Motivation

  • Decouples asm configurations from tracing
  • Avoids storing duplicate references for global configurations. Ideally global configurations should have once source of truth. This will help simplify remote configuration.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Dec 19, 2024

CODEOWNERS have been resolved as:

ddtrace/_trace/tracer.py                                                @DataDog/apm-sdk-api-python
ddtrace/appsec/_remoteconfiguration.py                                  @DataDog/asm-python
ddtrace/contrib/internal/requests/connection.py                         @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/pin.py                                                          @DataDog/apm-sdk-api-python
ddtrace/settings/asm.py                                                 @DataDog/asm-python
tests/appsec/appsec/test_asm_standalone.py                              @DataDog/asm-python
tests/appsec/contrib_appsec/utils.py                                    @DataDog/asm-python
tests/appsec/utils.py                                                   @DataDog/asm-python
tests/contrib/django/test_django_appsec.py                              @DataDog/asm-python
tests/contrib/django/test_django_appsec_iast.py                         @DataDog/asm-python
tests/contrib/djangorestframework/test_appsec.py                        @DataDog/asm-python
tests/contrib/fastapi/test_fastapi_appsec.py                            @DataDog/asm-python
tests/contrib/fastapi/test_fastapi_appsec_iast.py                       @DataDog/asm-python
tests/contrib/flask/test_flask_appsec.py                                @DataDog/asm-python
tests/contrib/flask/test_flask_appsec_iast.py                           @DataDog/asm-python
tests/contrib/flask/test_flask_appsec_telemetry.py                      @DataDog/asm-python
tests/contrib/requests/test_requests_distributed.py                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/urllib3/test_urllib3.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python
tests/tracer/test_tracer.py                                             @DataDog/apm-sdk-api-python

@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Benchmark execution time: 2024-12-20 19:07:56

Comparing candidate commit 9c66728 in PR branch munir/remove-asm-properties-from-the-tracer with baseline commit 2813291 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur force-pushed the munir/remove-asm-properties-from-the-tracer branch from a2713a3 to 6cd501f Compare December 19, 2024 18:31
@mabdinur mabdinur force-pushed the munir/remove-asm-properties-from-the-tracer branch from 6cd501f to 4bb4c5e Compare December 19, 2024 22:56
@mabdinur mabdinur marked this pull request as ready for review December 19, 2024 22:56
@mabdinur mabdinur requested review from a team as code owners December 19, 2024 22:56
ddtrace/pin.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant