-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracer): remove asm properties from the tracer class #11791
Open
mabdinur
wants to merge
6
commits into
main
Choose a base branch
from
munir/remove-asm-properties-from-the-tracer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BenchmarksBenchmark execution time: 2024-12-20 19:07:56 Comparing candidate commit 9c66728 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
mabdinur
force-pushed
the
munir/remove-asm-properties-from-the-tracer
branch
from
December 19, 2024 18:31
a2713a3
to
6cd501f
Compare
mabdinur
force-pushed
the
munir/remove-asm-properties-from-the-tracer
branch
from
December 19, 2024 22:56
6cd501f
to
4bb4c5e
Compare
mabdinur
requested review from
rachelyangdog,
emmettbutler,
wantsui and
P403n1x87
December 19, 2024 22:56
mabdinur
commented
Dec 19, 2024
mabdinur
commented
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes and use
asm_config
instead:Next steps:
tracer.py
.Motivation
Checklist
Reviewer Checklist