Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): memory leak in aspect modulo #11787

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Dec 19, 2024

a memory leak was introduced in #11601
This PR reverts it.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added ASM Application Security Monitoring backport 2.18 labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/_taint_tracking/Aspects/AspectModulo.cpp           @DataDog/asm-python

@avara1986 avara1986 marked this pull request as ready for review December 19, 2024 08:57
@avara1986 avara1986 requested review from a team as code owners December 19, 2024 08:57
@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. and removed backport 2.18 labels Dec 19, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Benchmark execution time: 2024-12-19 19:04:34

Comparing candidate commit 963efe9 in PR branch avara1986/revert_modulo with baseline commit 89d82c3 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 393 metrics, 2 unstable metrics.

scenario:iast_aspects-modulo_aspect_for_bytearray_bytearray

  • 🟥 execution_time [+107.812ns; +131.415ns] or [+7.156%; +8.722%]

@avara1986 avara1986 changed the title fix(iast): memory leak in aspect modulo chore(iast): memory leak in aspect modulo Dec 19, 2024
@avara1986 avara1986 closed this Dec 19, 2024
@avara1986 avara1986 reopened this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants