Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update supported versions #11767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Update the supported versions table.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 17, 2024
@github-actions github-actions bot requested a review from a team as a code owner December 17, 2024 23:48
@github-actions github-actions bot force-pushed the upgrade-supported-versions branch from f1f91f4 to d85091c Compare December 18, 2024 15:54
@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2024

Benchmarks

Benchmark execution time: 2024-12-19 15:47:01

Comparing candidate commit 117fdd8 in PR branch upgrade-supported-versions with baseline commit 2813291 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Copy link
Collaborator

@emmettbutler emmettbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it creates the table rather than updating it. @quinna-h is there any context to add about this change?

@github-actions github-actions bot force-pushed the upgrade-supported-versions branch from d85091c to 117fdd8 Compare December 19, 2024 15:03
quinna-h added a commit that referenced this pull request Dec 19, 2024
- Creates a `Generate Supported Integration Versions` workflow that
outputs the supported versions of integrations to a
`supported_versions_output.json` and `supported_versions_table.csv`. PR
here: #11767 and workflow
here:
https://github.com/DataDog/dd-trace-py/actions/runs/12383562860/job/34566489841
- in `scripts/freshvenvs.py`, separates the workflows for outputting the
outdated integrations (which is run in the `Generate Package Versions`
workflow), and for creating the supported version table.
- This workflow will be tied to a release, but can also be triggered
manually (via `workflow_dispatch`)

Future:
- There will be a mechanism for converting the `csv` file to the `rst`
format used by the ddtrace docs, and for generating the public datadoghq
docs (in markdown)

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants