-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clarify usage and wording for current_root_span #11764
Conversation
|
BenchmarksBenchmark execution time: 2025-01-08 21:44:44 Comparing candidate commit a8486ab in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 391 metrics, 2 unstable metrics. scenario:iast_aspects-ospathsplit_aspect
scenario:iast_aspects-ospathsplitext_aspect
scenario:iast_aspects-split_aspect
|
/merge |
Devflow running:
|
/remove |
Devflow running:
|
Datadog ReportBranch report: ✅ 0 Failed, 87 Passed, 1468 Skipped, 3m 41.98s Total duration (35m 26.08s time saved) |
Following up on #9758, our current definition of current_root_span is a bit misleading. This attempts to clarify the definition since in a distributed trace, you can't actually use this to grab the root span. (The only thing it consistently returns is "local root").
Checklist
Reviewer Checklist