Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(gevent): improve ddtrace-run test assertion message #11740

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Dec 16, 2024

This job can fail with exit code -11, but no additional context is provided, likely because there isn't anything on stderr ?

This updates the job to output stderr and stdout when the resulting process signal is not 0.

I was unable to reproduce the issue locally, so this is an attempt to collect more data when it fails on CI.

Example failure:

>       assert p.returncode == 0, stderr.decode()
E       AssertionError: 
E       assert -11 == 0
E        +  where -11 = <subprocess.Popen object at 0x7f3144d97eb0>.returncode

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 16, 2024
@brettlangdon brettlangdon requested review from a team as code owners December 16, 2024 17:35
Copy link
Contributor

github-actions bot commented Dec 16, 2024

CODEOWNERS have been resolved as:

tests/contrib/gevent/test_tracer.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/suitespec.yml                                             @DataDog/apm-core-python @DataDog/apm-idm-python

@pr-commenter
Copy link

pr-commenter bot commented Dec 16, 2024

Benchmarks

Benchmark execution time: 2024-12-17 16:01:44

Comparing candidate commit 5aa0c37 in PR branch brettlangdon/improve.assertion with baseline commit a4f0e38 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@sanchda
Copy link
Contributor

sanchda commented Dec 16, 2024

11 is a segfault--do we have crashtracking?

@brettlangdon
Copy link
Member Author

11 is a segfault--do we have crashtracking?

Let me check again, it should be enabled by default with ddtrace-run, I was surprised to not find it.

@brettlangdon
Copy link
Member Author

I also updated this job to have it not use the test agent.

@brettlangdon brettlangdon requested a review from a team as a code owner December 17, 2024 14:38
@brettlangdon brettlangdon requested a review from juanjux December 17, 2024 14:38
@brettlangdon brettlangdon force-pushed the brettlangdon/improve.assertion branch from 21f9fa3 to 090b2eb Compare December 17, 2024 15:00
.gitlab/services.yml Outdated Show resolved Hide resolved
@brettlangdon brettlangdon enabled auto-merge (squash) December 17, 2024 15:19
@brettlangdon brettlangdon merged commit 55c8dd0 into main Dec 20, 2024
541 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/improve.assertion branch December 20, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants