Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): more tests for libdd and stack_v2 #11679

Merged
merged 35 commits into from
Dec 20, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Dec 11, 2024

First copied files from tests/profiling folder, and then modified them as needed. Tests checking for agent export urls are dropped. libdd exporter is created with agent url passed from tracer state whenever we try to upload, see feat(profiling): support dynamic agent url

These tests will be run under libdd_enabled and some of them had been edited to also run under stack_v2 enabled

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Dec 11, 2024

CODEOWNERS have been resolved as:

tests/profiling_v2/simple_program.py                                    @DataDog/profiling-python
tests/profiling_v2/simple_program_fork.py                               @DataDog/profiling-python
tests/profiling_v2/simple_program_gevent.py                             @DataDog/profiling-python
tests/profiling_v2/test_accuracy.py                                     @DataDog/profiling-python
tests/profiling_v2/test_main.py                                         @DataDog/profiling-python
tests/profiling_v2/test_profiler.py                                     @DataDog/profiling-python
tests/profiling_v2/test_scheduler.py                                    @DataDog/profiling-python
tests/profiling/collector/test_stack.py                                 @DataDog/profiling-python
tests/profiling/test_accuracy.py                                        @DataDog/profiling-python
tests/profiling_v2/collector/test_stack.py                              @DataDog/profiling-python

@taegyunkim taegyunkim added Profiling Continous Profling changelog/no-changelog A changelog entry is not required for this PR. labels Dec 11, 2024
@taegyunkim taegyunkim marked this pull request as ready for review December 11, 2024 19:02
@taegyunkim taegyunkim requested a review from a team as a code owner December 11, 2024 19:02
@taegyunkim taegyunkim marked this pull request as draft December 11, 2024 19:18
@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2024

Benchmarks

Benchmark execution time: 2024-12-20 18:47:43

Comparing candidate commit e6750cc in PR branch taegyunkim/prof-10736-copy-tests with baseline commit 6ea56c5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@taegyunkim taegyunkim marked this pull request as ready for review December 11, 2024 22:38
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Dec 12, 2024

Datadog Report

Branch report: taegyunkim/prof-10736-copy-tests
Commit report: 819910b
Test service: dd-trace-py

✅ 0 Failed, 802 Passed, 666 Skipped, 15m 27.28s Total duration (21m 20.05s time saved)

Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly I haven't closely scrutinized every single test, but generally looks good. Left one note about a flaky test.

tests/profiling_v2/test_accuracy.py Outdated Show resolved Hide resolved
@taegyunkim taegyunkim merged commit 4beaa01 into main Dec 20, 2024
252 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/prof-10736-copy-tests branch December 20, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants