-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(profiling): more tests for libdd and stack_v2 #11679
Conversation
|
BenchmarksBenchmark execution time: 2024-12-20 18:47:43 Comparing candidate commit e6750cc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
Datadog ReportBranch report: ✅ 0 Failed, 802 Passed, 666 Skipped, 15m 27.28s Total duration (21m 20.05s time saved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admittedly I haven't closely scrutinized every single test, but generally looks good. Left one note about a flaky test.
First copied files from tests/profiling folder, and then modified them as needed. Tests checking for agent export urls are dropped. libdd exporter is created with agent url passed from tracer state whenever we try to upload, see feat(profiling): support dynamic agent url
These tests will be run under libdd_enabled and some of them had been edited to also run under stack_v2 enabled
Checklist
Reviewer Checklist