-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(asm): standalone sca billing #11655
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11655 +/- ##
==========================================
- Coverage 14.05% 14.03% -0.02%
==========================================
Files 1545 1547 +2
Lines 134562 134265 -297
==========================================
- Hits 18907 18841 -66
+ Misses 115655 115424 -231 ☔ View full report in Codecov by Sentry. |
7 tasks
juanjux
approved these changes
Dec 17, 2024
rachelyangdog
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASM: This PR introduces the "Standalone SCA billing" feature, that can be enabled by setting the following env vars to
"true"
or1
:DD_APPSEC_SCA_ENABLED
DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED
With them enabled, the service will opt out for APM features, thus being billed only for the SCA feature.
System-tests: DataDog/system-tests#3690
Checklist
Reviewer Checklist