Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use zip instead of tar for the tracer flare [backport 2.10] #10078

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 5, 2024

Backport 26682f8 from #10019 to 2.10.

System tests require the flare to be a zip, not a tar file.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions github-actions bot requested a review from a team as a code owner August 5, 2024 14:31
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 5, 2024
@github-actions github-actions bot requested a review from emmettbutler August 5, 2024 14:31
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 5, 2024

Datadog Report

Branch report: backport-10019-to-2.10
Commit report: 8cb056d
Test service: dd-trace-py

✅ 0 Failed, 147825 Passed, 25470 Skipped, 6h 9m 12.09s Total duration (3h 17m 4.66s time saved)
⌛ 1 Performance Regression

⌛ Performance Regressions vs Default Branch (1)

  • test_schematized_service_names[v1] - test_djangorestframework.py 7.13s (+5.84s, +452%) - Details

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 10.20%. Comparing base (4d99cf0) to head (8cb056d).
Report is 22 commits behind head on 2.10.

Files with missing lines Patch % Lines
ddtrace/internal/flare/flare.py 25.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             2.10   #10078       +/-   ##
===========================================
- Coverage   74.24%   10.20%   -64.05%     
===========================================
  Files        1332     1313       -19     
  Lines      126730   125190     -1540     
===========================================
- Hits        94096    12777    -81319     
- Misses      32634   112413    +79779     
Flag Coverage Δ
10.20% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Aug 5, 2024

Benchmarks

Benchmark execution time: 2024-09-30 19:56:49

Comparing candidate commit 8cb056d in PR branch backport-10019-to-2.10 with baseline commit 6b38e75 in branch 2.10.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 207 metrics, 9 unstable metrics.

System tests require the flare to be a zip, not a tar file.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 26682f8)
@taegyunkim taegyunkim force-pushed the backport-10019-to-2.10 branch from 8b51e70 to 3977bad Compare August 5, 2024 21:48
@taegyunkim taegyunkim enabled auto-merge (squash) August 5, 2024 21:48
@taegyunkim taegyunkim merged commit 21ed327 into 2.10 Sep 30, 2024
151 checks passed
@taegyunkim taegyunkim deleted the backport-10019-to-2.10 branch September 30, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants