-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use zip instead of tar for the tracer flare [backport 2.10] #10078
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 147825 Passed, 25470 Skipped, 6h 9m 12.09s Total duration (3h 17m 4.66s time saved) ⌛ Performance Regressions vs Default Branch (1)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #10078 +/- ##
===========================================
- Coverage 74.24% 10.20% -64.05%
===========================================
Files 1332 1313 -19
Lines 126730 125190 -1540
===========================================
- Hits 94096 12777 -81319
- Misses 32634 112413 +79779
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
System tests require the flare to be a zip, not a tar file. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 26682f8)
8b51e70
to
3977bad
Compare
Backport 26682f8 from #10019 to 2.10.
System tests require the flare to be a zip, not a tar file.
Checklist
Reviewer Checklist