Skip to content

Commit

Permalink
fix(iast): add some modules to the denylist [backport 2.15] (#11432)
Browse files Browse the repository at this point in the history
Backport 343ba22 from #11418 to 2.15.

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Juanjo Alvarez Martinez <[email protected]>
  • Loading branch information
github-actions[bot] and juanjux authored Nov 18, 2024
1 parent 39e8b92 commit 01215f1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ddtrace/appsec/_iast/_ast/ast_patching.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,9 @@
"httpcore.",
"google.auth.",
"googlecloudsdk.",
"umap.",
"pynndescent.",
"numba.",
)


Expand Down Expand Up @@ -367,7 +370,6 @@ def visit_ast(
module_name: Text = "",
) -> Optional[str]:
parsed_ast = ast.parse(source_text, module_path)

_VISITOR.update_location(filename=module_path, module_name=module_name)
modified_ast = _VISITOR.visit(parsed_ast)

Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/umap-learn-denylist-b7c55f42f2408c24.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
fixes:
- |
Code Security: add umap, numba and pynndescent to the Code Security denylist.

0 comments on commit 01215f1

Please sign in to comment.