build: shrink profiling artifacts with panic=abort
#2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrisonlevi
force-pushed
the
levi/shrink-build
branch
from
af69395 to
c468b5b
Compare
morrisonlevi
force-pushed
the
levi/shrink-build
branch
from
694b7ce to
889d636
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2601 +/- ##
============================================
- Coverage 79.37% 77.77% -1.60%
Complexity 2198 2198
============================================
Files 199 225 +26
Lines 21955 25955 +4000
Branches 0 986 +986
============================================
+ Hits 17426 20186 +2760
- Misses 4529 5243 +714
- Partials 0 526 +526
Flags with carried forward coverage won't be shown. Click here to find out more. see 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
I gave it a spin and the release binary on |
ci: use rustup-init instead of tarball This is done because the tarball does not include rust-src. ci: parameterized ZTS/NTS for build_profiler task
morrisonlevi
force-pushed
the
levi/shrink-build
branch
from
829cbd4 to
df44977
Compare
BenchmarksBenchmark execution time: 2024-04-16 01:22:05 Comparing candidate commit 829cbd4 in PR branch Found 3 performance improvements and 5 performance regressions! Performance is the same for 170 metrics, 0 unstable metrics. scenario:ContextPropagationBench/benchInject64Bit-opcache
scenario:LogsInjectionBench/benchLogsInfoInjection-opcache
scenario:PDOBench/benchPDOBaseline
scenario:PDOBench/benchPDOBaseline-opcache
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverheadWithDBM
scenario:SamplingRuleMatchingBench/benchRegexMatching2-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching3
|
morrisonlevi
force-pushed
the
levi/shrink-build
branch
from
f1279b5 to
ce05987
Compare
morrisonlevi
changed the title
morrisonlevi
changed the title
panic=abort
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently the build artifacts got quite large due to the tracer including debug symbols for things. The profiler has also been creeping up in size, and so I thought I'd try to shrink the build artifacts. These all seem to individually give small decreases in size:
codegen-units=1lto="fat"debug="line-tables-only"panic=abort-Z build-std="panic_abort,core,alloc,std". However, this requires nightly, to avoid this, we use theRUSTC_BOOTSTRAP=1hack.Note that if you are buliding locally to try to reproduce savings, we also compress with
objcopy --compress-debug-sectionsafterwards.Reviewer checklist