Skip to content

Activate client stats by default for java 17 services #9463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Activate client stats by default for java 17 services #9463

wants to merge 1 commit into from

Conversation

amarziali
Copy link
Contributor

@amarziali amarziali commented Sep 4, 2025 •
edited by bric3
Loading

What Does This Do

Activates CSS by default for java 17 services

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner September 4, 2025 10:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@amarziali amarziali requested review from bric3 and ichinaski September 4, 2025 10:25
@datadog-official Datadog Official
Copy link

datadog-official bot commented Sep 4, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 57.66% (+0.06%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9374c82 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/activate-css-java17
git_commit_date 1756980241 1756981338
git_commit_sha 35a825a 9374c82
release_version 1.54.0-SNAPSHOT~35a825a3f4 1.54.0-SNAPSHOT~9374c8254f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1756983175 1756983175
ci_job_id 1113152159 1113152159
ci_pipeline_id 75522432 75522432
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-fk5pyyiw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-fk5pyyiw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 6 performance regressions! Performance is the same for 39 metrics, 14 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:GlobalTracer worse
[+8.050ms; +16.165ms] or [+3.460%; +6.948%]		 244.762ms 232.655ms
scenario:startup:insecure-bank:tracing:GlobalTracer worse
[+8.896ms; +11.146ms] or [+3.694%; +4.628%]		 250.873ms 240.852ms
scenario:startup:petclinic:appsec:GlobalTracer worse
[+9.201ms; +12.001ms] or [+3.930%; +5.126%]		 244.717ms 234.116ms
scenario:startup:petclinic:iast:GlobalTracer worse
[+9.155ms; +16.330ms] or [+3.933%; +7.016%]		 245.498ms 232.756ms
scenario:startup:petclinic:profiling:GlobalTracer worse
[+8.528ms; +11.100ms] or [+3.843%; +5.002%]		 231.732ms 221.918ms
scenario:startup:petclinic:tracing:GlobalTracer worse
[+8.536ms; +16.803ms] or [+3.537%; +6.963%]		 253.979ms 241.309ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~9374c8254f, baseline=1.54.0-SNAPSHOT~35a825a3f4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046232
Total [baseline] (8.618 s) : 0, 8617870
Agent [candidate] (1.059 s) : 0, 1059288
Total [candidate] (8.651 s) : 0, 8651075
section iast
Agent [baseline] (1.177 s) : 0, 1177097
Total [baseline] (9.356 s) : 0, 9355798
Agent [candidate] (1.196 s) : 0, 1195711
Total [candidate] (9.33 s) : 0, 9330236
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.177 s 130.865 ms (12.5%)
Total tracing 8.618 s -
Total iast 9.356 s 737.929 ms (8.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent iast 1.196 s 136.422 ms (12.9%)
Total tracing 8.651 s -
Total iast 9.33 s 679.161 ms (7.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~9374c8254f, baseline=1.54.0-SNAPSHOT~35a825a3f4

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (732.393 ms) : 0, 732393
BytebuddyAgent [candidate] (732.549 ms) : 0, 732549
GlobalTracer [baseline] (240.852 ms) : 0, 240852
GlobalTracer [candidate] (250.873 ms) : 0, 250873
AppSec [baseline] (30.111 ms) : 0, 30111
AppSec [candidate] (30.315 ms) : 0, 30315
Debugger [baseline] (6.141 ms) : 0, 6141
Debugger [candidate] (6.048 ms) : 0, 6048
Remote Config [baseline] (668.123 µs) : 0, 668
Remote Config [candidate] (693.163 µs) : 0, 693
Telemetry [baseline] (13.643 ms) : 0, 13643
Telemetry [candidate] (16.344 ms) : 0, 16344
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (850.811 ms) : 0, 850811
BytebuddyAgent [candidate] (858.261 ms) : 0, 858261
GlobalTracer [baseline] (232.655 ms) : 0, 232655
GlobalTracer [candidate] (244.762 ms) : 0, 244762
AppSec [baseline] (26.698 ms) : 0, 26698
AppSec [candidate] (26.322 ms) : 0, 26322
Debugger [baseline] (6.556 ms) : 0, 6556
Debugger [candidate] (5.78 ms) : 0, 5780
Remote Config [baseline] (601.938 µs) : 0, 602
Remote Config [candidate] (594.387 µs) : 0, 594
Telemetry [baseline] (8.107 ms) : 0, 8107
Telemetry [candidate] (8.262 ms) : 0, 8262
IAST [baseline] (29.213 ms) : 0, 29213
IAST [candidate] (29.196 ms) : 0, 29196
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~9374c8254f, baseline=1.54.0-SNAPSHOT~35a825a3f4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047682
Total [baseline] (10.614 s) : 0, 10613692
Agent [candidate] (1.065 s) : 0, 1065207
Total [candidate] (10.758 s) : 0, 10757527
section appsec
Agent [baseline] (1.223 s) : 0, 1223127
Total [baseline] (10.786 s) : 0, 10785546
Agent [candidate] (1.235 s) : 0, 1234689
Total [candidate] (10.901 s) : 0, 10900541
section iast
Agent [baseline] (1.187 s) : 0, 1187474
Total [baseline] (10.972 s) : 0, 10972233
Agent [candidate] (1.188 s) : 0, 1188012
Total [candidate] (11.055 s) : 0, 11055010
section profiling
Agent [baseline] (1.197 s) : 0, 1197297
Total [baseline] (10.917 s) : 0, 10916833
Agent [candidate] (1.21 s) : 0, 1209852
Total [candidate] (10.94 s) : 0, 10940128
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.223 s 175.446 ms (16.7%)
Agent iast 1.187 s 139.792 ms (13.3%)
Agent profiling 1.197 s 149.615 ms (14.3%)
Total tracing 10.614 s -
Total appsec 10.786 s 171.854 ms (1.6%)
Total iast 10.972 s 358.541 ms (3.4%)
Total profiling 10.917 s 303.141 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.235 s 169.482 ms (15.9%)
Agent iast 1.188 s 122.805 ms (11.5%)
Agent profiling 1.21 s 144.645 ms (13.6%)
Total tracing 10.758 s -
Total appsec 10.901 s 143.014 ms (1.3%)
Total iast 11.055 s 297.483 ms (2.8%)
Total profiling 10.94 s 182.601 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~9374c8254f, baseline=1.54.0-SNAPSHOT~35a825a3f4

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (733.842 ms) : 0, 733842
BytebuddyAgent [candidate] (734.656 ms) : 0, 734656
GlobalTracer [baseline] (241.309 ms) : 0, 241309
GlobalTracer [candidate] (253.979 ms) : 0, 253979
AppSec [baseline] (30.235 ms) : 0, 30235
AppSec [candidate] (30.759 ms) : 0, 30759
Debugger [baseline] (6.087 ms) : 0, 6087
Debugger [candidate] (6.127 ms) : 0, 6127
Remote Config [baseline] (684.46 µs) : 0, 684
Remote Config [candidate] (694.543 µs) : 0, 695
Telemetry [baseline] (12.922 ms) : 0, 12922
Telemetry [candidate] (16.39 ms) : 0, 16390
section appsec
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (756.633 ms) : 0, 756633
BytebuddyAgent [candidate] (758.222 ms) : 0, 758222
GlobalTracer [baseline] (234.116 ms) : 0, 234116
GlobalTracer [candidate] (244.717 ms) : 0, 244717
IAST [baseline] (23.48 ms) : 0, 23480
IAST [candidate] (23.741 ms) : 0, 23741
AppSec [baseline] (169.053 ms) : 0, 169053
AppSec [candidate] (170.578 ms) : 0, 170578
Debugger [baseline] (7.42 ms) : 0, 7420
Debugger [candidate] (5.76 ms) : 0, 5760
Remote Config [baseline] (622.088 µs) : 0, 622
Remote Config [candidate] (642.635 µs) : 0, 643
Telemetry [baseline] (9.233 ms) : 0, 9233
Telemetry [candidate] (8.357 ms) : 0, 8357
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (859.273 ms) : 0, 859273
BytebuddyAgent [candidate] (852.468 ms) : 0, 852468
GlobalTracer [baseline] (232.756 ms) : 0, 232756
GlobalTracer [candidate] (245.498 ms) : 0, 245498
IAST [baseline] (32.735 ms) : 0, 32735
IAST [candidate] (28.05 ms) : 0, 28050
AppSec [baseline] (24.555 ms) : 0, 24555
AppSec [candidate] (25.156 ms) : 0, 25156
Debugger [baseline] (6.573 ms) : 0, 6573
Debugger [candidate] (5.685 ms) : 0, 5685
Remote Config [baseline] (611.489 µs) : 0, 611
Remote Config [candidate] (586.919 µs) : 0, 587
Telemetry [baseline] (8.282 ms) : 0, 8282
Telemetry [candidate] (7.992 ms) : 0, 7992
section profiling
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (762.426 ms) : 0, 762426
BytebuddyAgent [candidate] (762.964 ms) : 0, 762964
GlobalTracer [baseline] (221.918 ms) : 0, 221918
GlobalTracer [candidate] (231.732 ms) : 0, 231732
AppSec [baseline] (31.322 ms) : 0, 31322
AppSec [candidate] (31.035 ms) : 0, 31035
Debugger [baseline] (6.283 ms) : 0, 6283
Debugger [candidate] (6.372 ms) : 0, 6372
Remote Config [baseline] (716.702 µs) : 0, 717
Remote Config [candidate] (680.361 µs) : 0, 680
Telemetry [baseline] (14.851 ms) : 0, 14851
Telemetry [candidate] (15.888 ms) : 0, 15888
ProfilingAgent [baseline] (107.944 ms) : 0, 107944
ProfilingAgent [candidate] (109.19 ms) : 0, 109190
Profiling [baseline] (108.601 ms) : 0, 108601
Profiling [candidate] (109.81 ms) : 0, 109810
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/activate-css-java17
git_commit_date 1756980241 1756981338
git_commit_sha 35a825a 9374c82
release_version 1.54.0-SNAPSHOT~35a825a3f4 1.54.0-SNAPSHOT~9374c8254f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1756982859 1756982859
ci_job_id 1113152160 1113152160
ci_pipeline_id 75522432 75522432
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-t3utcctq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-t3utcctq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load better
[-228.656µs; -119.844µs] or [-5.011%; -2.626%]		 unstable
[-81.774op/s; +160.337op/s] or [-8.125%; +15.932%]		 4.389ms 1045.688op/s 4.563ms 1006.406op/s
scenario:load:petclinic:no_agent:high_load better
[-3.136ms; -2.477ms] or [-8.220%; -6.494%]		 unstable
[+1.010op/s; +18.365op/s] or [+0.824%; +14.984%]		 35.340ms 132.250op/s 38.146ms 122.562op/s
scenario:load:petclinic:code_origins:high_load worse
[+0.997ms; +1.858ms] or [+2.231%; +4.156%]		 unstable
[-11.382op/s; +2.332op/s] or [-10.740%; +2.201%]		 46.129ms 101.450op/s 44.701ms 105.975op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~9374c8254f, baseline=1.54.0-SNAPSHOT~35a825a3f4
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.563 ms) : 4511, 4615
.   : milestone, 4563,
iast (9.065 ms) : 8920, 9209
.   : milestone, 9065,
iast_FULL (13.866 ms) : 13589, 14144
.   : milestone, 13866,
iast_GLOBAL (10.642 ms) : 10455, 10830
.   : milestone, 10642,
profiling (8.764 ms) : 8627, 8902
.   : milestone, 8764,
tracing (7.538 ms) : 7432, 7644
.   : milestone, 7538,
section candidate
no_agent (4.389 ms) : 4339, 4438
.   : milestone, 4389,
iast (9.109 ms) : 8963, 9254
.   : milestone, 9109,
iast_FULL (14.079 ms) : 13802, 14355
.   : milestone, 14079,
iast_GLOBAL (10.452 ms) : 10270, 10634
.   : milestone, 10452,
profiling (8.676 ms) : 8534, 8819
.   : milestone, 8676,
tracing (7.529 ms) : 7424, 7634
.   : milestone, 7529,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.563 ms [4.511 ms, 4.615 ms] -
iast 9.065 ms [8.92 ms, 9.209 ms] 4.502 ms (98.7%)
iast_FULL 13.866 ms [13.589 ms, 14.144 ms] 9.304 ms (203.9%)
iast_GLOBAL 10.642 ms [10.455 ms, 10.83 ms] 6.079 ms (133.2%)
profiling 8.764 ms [8.627 ms, 8.902 ms] 4.201 ms (92.1%)
tracing 7.538 ms [7.432 ms, 7.644 ms] 2.975 ms (65.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.389 ms [4.339 ms, 4.438 ms] -
iast 9.109 ms [8.963 ms, 9.254 ms] 4.72 ms (107.5%)
iast_FULL 14.079 ms [13.802 ms, 14.355 ms] 9.69 ms (220.8%)
iast_GLOBAL 10.452 ms [10.27 ms, 10.634 ms] 6.064 ms (138.2%)
profiling 8.676 ms [8.534 ms, 8.819 ms] 4.288 ms (97.7%)
tracing 7.529 ms [7.424 ms, 7.634 ms] 3.14 ms (71.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~9374c8254f, baseline=1.54.0-SNAPSHOT~35a825a3f4
    dateFormat X
    axisFormat %s
section baseline
no_agent (38.146 ms) : 37825, 38468
.   : milestone, 38146,
appsec (47.494 ms) : 47080, 47908
.   : milestone, 47494,
code_origins (44.701 ms) : 44304, 45099
.   : milestone, 44701,
iast (44.789 ms) : 44382, 45195
.   : milestone, 44789,
profiling (49.409 ms) : 48948, 49869
.   : milestone, 49409,
tracing (43.233 ms) : 42866, 43600
.   : milestone, 43233,
section candidate
no_agent (35.34 ms) : 35051, 35629
.   : milestone, 35340,
appsec (47.966 ms) : 47546, 48385
.   : milestone, 47966,
code_origins (46.129 ms) : 45726, 46532
.   : milestone, 46129,
iast (44.748 ms) : 44351, 45145
.   : milestone, 44748,
profiling (49.07 ms) : 48612, 49528
.   : milestone, 49070,
tracing (43.625 ms) : 43266, 43984
.   : milestone, 43625,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 38.146 ms [37.825 ms, 38.468 ms] -
appsec 47.494 ms [47.08 ms, 47.908 ms] 9.348 ms (24.5%)
code_origins 44.701 ms [44.304 ms, 45.099 ms] 6.555 ms (17.2%)
iast 44.789 ms [44.382 ms, 45.195 ms] 6.642 ms (17.4%)
profiling 49.409 ms [48.948 ms, 49.869 ms] 11.263 ms (29.5%)
tracing 43.233 ms [42.866 ms, 43.6 ms] 5.086 ms (13.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 35.34 ms [35.051 ms, 35.629 ms] -
appsec 47.966 ms [47.546 ms, 48.385 ms] 12.626 ms (35.7%)
code_origins 46.129 ms [45.726 ms, 46.532 ms] 10.789 ms (30.5%)
iast 44.748 ms [44.351 ms, 45.145 ms] 9.408 ms (26.6%)
profiling 49.07 ms [48.612 ms, 49.528 ms] 13.73 ms (38.9%)
tracing 43.625 ms [43.266 ms, 43.984 ms] 8.285 ms (23.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/activate-css-java17
git_commit_date 1756980241 1756981338
git_commit_sha 35a825a 9374c82
release_version 1.54.0-SNAPSHOT~35a825a3f4 1.54.0-SNAPSHOT~9374c8254f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1756983374 1756983374
ci_job_id 1113152161 1113152161
ci_pipeline_id 75522432 75522432
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-6e3aidxs 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-6e3aidxs 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~9374c8254f, baseline=1.54.0-SNAPSHOT~35a825a3f4
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.959 s) : 14959000, 14959000
.   : milestone, 14959000,
appsec (14.894 s) : 14894000, 14894000
.   : milestone, 14894000,
iast (18.405 s) : 18405000, 18405000
.   : milestone, 18405000,
iast_GLOBAL (18.271 s) : 18271000, 18271000
.   : milestone, 18271000,
profiling (15.969 s) : 15969000, 15969000
.   : milestone, 15969000,
tracing (14.971 s) : 14971000, 14971000
.   : milestone, 14971000,
section candidate
no_agent (15.718 s) : 15718000, 15718000
.   : milestone, 15718000,
appsec (15.053 s) : 15053000, 15053000
.   : milestone, 15053000,
iast (18.807 s) : 18807000, 18807000
.   : milestone, 18807000,
iast_GLOBAL (17.909 s) : 17909000, 17909000
.   : milestone, 17909000,
profiling (15.4 s) : 15400000, 15400000
.   : milestone, 15400000,
tracing (15.265 s) : 15265000, 15265000
.   : milestone, 15265000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.959 s [14.959 s, 14.959 s] -
appsec 14.894 s [14.894 s, 14.894 s] -65.0 ms (-0.4%)
iast 18.405 s [18.405 s, 18.405 s] 3.446 s (23.0%)
iast_GLOBAL 18.271 s [18.271 s, 18.271 s] 3.312 s (22.1%)
profiling 15.969 s [15.969 s, 15.969 s] 1.01 s (6.8%)
tracing 14.971 s [14.971 s, 14.971 s] 12.0 ms (0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.718 s [15.718 s, 15.718 s] -
appsec 15.053 s [15.053 s, 15.053 s] -665.0 ms (-4.2%)
iast 18.807 s [18.807 s, 18.807 s] 3.089 s (19.7%)
iast_GLOBAL 17.909 s [17.909 s, 17.909 s] 2.191 s (13.9%)
profiling 15.4 s [15.4 s, 15.4 s] -318.0 ms (-2.0%)
tracing 15.265 s [15.265 s, 15.265 s] -453.0 ms (-2.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~9374c8254f, baseline=1.54.0-SNAPSHOT~35a825a3f4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (3.673 ms) : 3457, 3888
.   : milestone, 3673,
iast (2.199 ms) : 2136, 2261
.   : milestone, 2199,
iast_GLOBAL (2.238 ms) : 2175, 2300
.   : milestone, 2238,
profiling (2.055 ms) : 2005, 2106
.   : milestone, 2055,
tracing (2.03 ms) : 1982, 2079
.   : milestone, 2030,
section candidate
no_agent (1.479 ms) : 1467, 1490
.   : milestone, 1479,
appsec (3.663 ms) : 3447, 3878
.   : milestone, 3663,
iast (2.211 ms) : 2149, 2274
.   : milestone, 2211,
iast_GLOBAL (2.243 ms) : 2180, 2306
.   : milestone, 2243,
profiling (2.075 ms) : 2023, 2128
.   : milestone, 2075,
tracing (2.022 ms) : 1973, 2070
.   : milestone, 2022,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 3.673 ms [3.457 ms, 3.888 ms] 2.196 ms (148.7%)
iast 2.199 ms [2.136 ms, 2.261 ms] 721.79 µs (48.9%)
iast_GLOBAL 2.238 ms [2.175 ms, 2.3 ms] 760.667 µs (51.5%)
profiling 2.055 ms [2.005 ms, 2.106 ms] 578.577 µs (39.2%)
tracing 2.03 ms [1.982 ms, 2.079 ms] 553.402 µs (37.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.467 ms, 1.49 ms] -
appsec 3.663 ms [3.447 ms, 3.878 ms] 2.184 ms (147.7%)
iast 2.211 ms [2.149 ms, 2.274 ms] 732.514 µs (49.5%)
iast_GLOBAL 2.243 ms [2.18 ms, 2.306 ms] 764.063 µs (51.7%)
profiling 2.075 ms [2.023 ms, 2.128 ms] 596.527 µs (40.3%)
tracing 2.022 ms [1.973 ms, 2.07 ms] 542.966 µs (36.7%)

PerfectSlayer
PerfectSlayer reviewed Sep 4, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 suggestion: ‏I would add a quick documentation about why Java Version filter is used (as an arbitrary rule for progressive rollout, not related to a Java feature)

AlexeyKuznetsov-DD
AlexeyKuznetsov-DD reviewed Sep 5, 2025
View reviewed changes
internal-api/src/main/java/datadog/trace/api/Config.java
@@ -1808,7 +1808,9 @@ private Config(final ConfigProvider configProvider, final InstrumenterConfig ins
// Enable tracer computed trace metrics by default for Azure Functions
tracerMetricsEnabled =
configProvider.getBoolean(
TRACE_STATS_COMPUTATION_ENABLED, azureFunctions, TRACER_METRICS_ENABLED);
TRACE_STATS_COMPUTATION_ENABLED,
azureFunctions || JavaVirtualMachine.isJavaVersion(17),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Does it make sense to check exact version? what would happened on 17+ Javas?
  2. Does it make sense to add test for Java 17(+ ?)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD left review comments

@bric3 bric3 bric3 approved these changes

@ichinaski ichinaski ichinaski approved these changes

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: metrics Metrics tag: experimental Experimental changes type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amarziali @bric3 @ichinaski @PerfectSlayer @AlexeyKuznetsov-DD