-
Notifications
You must be signed in to change notification settings - Fork 312
Fix NPE for keys with empty value in Stable Configuration #9461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...nal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfig.java
Outdated
Show resolved
Hide resolved
…ider/stableconfig/StableConfig.java Co-authored-by: Stuart McCulloch <[email protected]>
🎯 Code Coverage 🔗 Commit SHA: c4f244c | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~c4f244c568, baseline=1.54.0-SNAPSHOT~d8b9ae841a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051280
Total [baseline] (10.722 s) : 0, 10721515
Agent [candidate] (1.047 s) : 0, 1047483
Total [candidate] (10.721 s) : 0, 10721317
section appsec
Agent [baseline] (1.232 s) : 0, 1231726
Total [baseline] (10.873 s) : 0, 10872550
Agent [candidate] (1.228 s) : 0, 1227617
Total [candidate] (10.883 s) : 0, 10883264
section iast
Agent [baseline] (1.197 s) : 0, 1196943
Total [baseline] (11.057 s) : 0, 11057470
Agent [candidate] (1.191 s) : 0, 1190789
Total [candidate] (10.943 s) : 0, 10943105
section profiling
Agent [baseline] (1.216 s) : 0, 1215887
Total [baseline] (11.017 s) : 0, 11017295
Agent [candidate] (1.202 s) : 0, 1201640
Total [candidate] (10.889 s) : 0, 10888765
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~c4f244c568, baseline=1.54.0-SNAPSHOT~d8b9ae841a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (734.774 ms) : 0, 734774
BytebuddyAgent [candidate] (732.198 ms) : 0, 732198
GlobalTracer [baseline] (243.566 ms) : 0, 243566
GlobalTracer [candidate] (242.814 ms) : 0, 242814
AppSec [baseline] (30.412 ms) : 0, 30412
AppSec [candidate] (30.173 ms) : 0, 30173
Debugger [baseline] (6.15 ms) : 0, 6150
Debugger [candidate] (6.078 ms) : 0, 6078
Remote Config [baseline] (699.83 µs) : 0, 700
Remote Config [candidate] (678.689 µs) : 0, 679
Telemetry [baseline] (13.054 ms) : 0, 13054
Telemetry [candidate] (12.918 ms) : 0, 12918
section appsec
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (760.215 ms) : 0, 760215
BytebuddyAgent [candidate] (757.956 ms) : 0, 757956
GlobalTracer [baseline] (237.269 ms) : 0, 237269
GlobalTracer [candidate] (236.325 ms) : 0, 236325
IAST [baseline] (23.775 ms) : 0, 23775
IAST [candidate] (23.852 ms) : 0, 23852
AppSec [baseline] (168.144 ms) : 0, 168144
AppSec [candidate] (170.416 ms) : 0, 170416
Debugger [baseline] (9.663 ms) : 0, 9663
Debugger [candidate] (6.522 ms) : 0, 6522
Remote Config [baseline] (631.076 µs) : 0, 631
Remote Config [candidate] (610.87 µs) : 0, 611
Telemetry [baseline] (9.405 ms) : 0, 9405
Telemetry [candidate] (9.327 ms) : 0, 9327
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (864.999 ms) : 0, 864999
BytebuddyAgent [candidate] (860.084 ms) : 0, 860084
GlobalTracer [baseline] (235.015 ms) : 0, 235015
GlobalTracer [candidate] (234.519 ms) : 0, 234519
IAST [baseline] (28.742 ms) : 0, 28742
IAST [candidate] (29.743 ms) : 0, 29743
AppSec [baseline] (28.336 ms) : 0, 28336
AppSec [candidate] (27.053 ms) : 0, 27053
Debugger [baseline] (7.987 ms) : 0, 7987
Debugger [candidate] (7.604 ms) : 0, 7604
Remote Config [baseline] (639.68 µs) : 0, 640
Remote Config [candidate] (615.507 µs) : 0, 616
Telemetry [baseline] (8.418 ms) : 0, 8418
Telemetry [candidate] (8.355 ms) : 0, 8355
section profiling
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (774.718 ms) : 0, 774718
BytebuddyAgent [candidate] (764.054 ms) : 0, 764054
GlobalTracer [baseline] (224.909 ms) : 0, 224909
GlobalTracer [candidate] (222.722 ms) : 0, 222722
AppSec [baseline] (30.831 ms) : 0, 30831
AppSec [candidate] (30.629 ms) : 0, 30629
Debugger [baseline] (6.314 ms) : 0, 6314
Debugger [candidate] (6.266 ms) : 0, 6266
Remote Config [baseline] (716.502 µs) : 0, 717
Remote Config [candidate] (706.605 µs) : 0, 707
Telemetry [baseline] (16.516 ms) : 0, 16516
Telemetry [candidate] (16.497 ms) : 0, 16497
ProfilingAgent [baseline] (109.215 ms) : 0, 109215
ProfilingAgent [candidate] (108.655 ms) : 0, 108655
Profiling [baseline] (109.904 ms) : 0, 109904
Profiling [candidate] (109.311 ms) : 0, 109311
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~c4f244c568, baseline=1.54.0-SNAPSHOT~d8b9ae841a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050890
Total [baseline] (8.642 s) : 0, 8641710
Agent [candidate] (1.051 s) : 0, 1051408
Total [candidate] (8.655 s) : 0, 8654959
section iast
Agent [baseline] (1.192 s) : 0, 1192359
Total [baseline] (9.344 s) : 0, 9344125
Agent [candidate] (1.186 s) : 0, 1185687
Total [candidate] (9.33 s) : 0, 9330029
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~c4f244c568, baseline=1.54.0-SNAPSHOT~d8b9ae841a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (734.907 ms) : 0, 734907
BytebuddyAgent [candidate] (736.48 ms) : 0, 736480
GlobalTracer [baseline] (243.107 ms) : 0, 243107
GlobalTracer [candidate] (242.817 ms) : 0, 242817
AppSec [baseline] (30.313 ms) : 0, 30313
AppSec [candidate] (30.178 ms) : 0, 30178
Debugger [baseline] (6.084 ms) : 0, 6084
Debugger [candidate] (6.101 ms) : 0, 6101
Remote Config [baseline] (693.562 µs) : 0, 694
Remote Config [candidate] (694.432 µs) : 0, 694
Telemetry [baseline] (13.152 ms) : 0, 13152
Telemetry [candidate] (12.431 ms) : 0, 12431
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (861.385 ms) : 0, 861385
BytebuddyAgent [candidate] (856.459 ms) : 0, 856459
GlobalTracer [baseline] (234.646 ms) : 0, 234646
GlobalTracer [candidate] (234.495 ms) : 0, 234495
IAST [baseline] (29.828 ms) : 0, 29828
IAST [candidate] (29.49 ms) : 0, 29490
AppSec [baseline] (27.97 ms) : 0, 27970
AppSec [candidate] (27.031 ms) : 0, 27031
Debugger [baseline] (6.784 ms) : 0, 6784
Debugger [candidate] (6.671 ms) : 0, 6671
Remote Config [baseline] (632.911 µs) : 0, 633
Remote Config [candidate] (610.951 µs) : 0, 611
Telemetry [baseline] (8.464 ms) : 0, 8464
Telemetry [candidate] (8.328 ms) : 0, 8328
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c4f244c568, baseline=1.54.0-SNAPSHOT~d8b9ae841a
dateFormat X
axisFormat %s
section baseline
no_agent (36.707 ms) : 36410, 37004
. : milestone, 36707,
appsec (47.134 ms) : 46727, 47541
. : milestone, 47134,
code_origins (46.596 ms) : 46182, 47010
. : milestone, 46596,
iast (44.478 ms) : 44112, 44843
. : milestone, 44478,
profiling (49.276 ms) : 48805, 49747
. : milestone, 49276,
tracing (44.056 ms) : 43668, 44444
. : milestone, 44056,
section candidate
no_agent (38.123 ms) : 37808, 38438
. : milestone, 38123,
appsec (47.504 ms) : 47081, 47928
. : milestone, 47504,
code_origins (45.418 ms) : 45027, 45809
. : milestone, 45418,
iast (46.002 ms) : 45598, 46407
. : milestone, 46002,
profiling (48.994 ms) : 48518, 49470
. : milestone, 48994,
tracing (44.221 ms) : 43855, 44587
. : milestone, 44221,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c4f244c568, baseline=1.54.0-SNAPSHOT~d8b9ae841a
dateFormat X
axisFormat %s
section baseline
no_agent (4.357 ms) : 4300, 4413
. : milestone, 4357,
iast (9.444 ms) : 9289, 9599
. : milestone, 9444,
iast_FULL (13.82 ms) : 13549, 14092
. : milestone, 13820,
iast_GLOBAL (10.031 ms) : 9851, 10211
. : milestone, 10031,
profiling (8.738 ms) : 8605, 8871
. : milestone, 8738,
tracing (7.633 ms) : 7527, 7739
. : milestone, 7633,
section candidate
no_agent (4.417 ms) : 4368, 4467
. : milestone, 4417,
iast (9.07 ms) : 8916, 9225
. : milestone, 9070,
iast_FULL (13.975 ms) : 13691, 14258
. : milestone, 13975,
iast_GLOBAL (10.525 ms) : 10338, 10711
. : milestone, 10525,
profiling (8.812 ms) : 8676, 8949
. : milestone, 8812,
tracing (7.59 ms) : 7473, 7707
. : milestone, 7590,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c4f244c568, baseline=1.54.0-SNAPSHOT~d8b9ae841a
dateFormat X
axisFormat %s
section baseline
no_agent (15.531 s) : 15531000, 15531000
. : milestone, 15531000,
appsec (14.926 s) : 14926000, 14926000
. : milestone, 14926000,
iast (18.559 s) : 18559000, 18559000
. : milestone, 18559000,
iast_GLOBAL (17.881 s) : 17881000, 17881000
. : milestone, 17881000,
profiling (15.569 s) : 15569000, 15569000
. : milestone, 15569000,
tracing (15.086 s) : 15086000, 15086000
. : milestone, 15086000,
section candidate
no_agent (15.539 s) : 15539000, 15539000
. : milestone, 15539000,
appsec (14.91 s) : 14910000, 14910000
. : milestone, 14910000,
iast (18.305 s) : 18305000, 18305000
. : milestone, 18305000,
iast_GLOBAL (17.849 s) : 17849000, 17849000
. : milestone, 17849000,
profiling (16.117 s) : 16117000, 16117000
. : milestone, 16117000,
tracing (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c4f244c568, baseline=1.54.0-SNAPSHOT~d8b9ae841a
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.687 ms) : 3469, 3906
. : milestone, 3687,
iast (2.213 ms) : 2150, 2276
. : milestone, 2213,
iast_GLOBAL (2.26 ms) : 2197, 2323
. : milestone, 2260,
profiling (2.046 ms) : 1996, 2097
. : milestone, 2046,
tracing (2.033 ms) : 1984, 2082
. : milestone, 2033,
section candidate
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (3.625 ms) : 3411, 3840
. : milestone, 3625,
iast (2.215 ms) : 2152, 2277
. : milestone, 2215,
iast_GLOBAL (2.257 ms) : 2195, 2320
. : milestone, 2257,
profiling (2.051 ms) : 2001, 2102
. : milestone, 2051,
tracing (2.024 ms) : 1975, 2072
. : milestone, 2024,
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
This PR fixes an issue where an
application_monitoring.yaml
file with contents:would create a stack trace at tracer startup.
Motivation
Cleaner startup!
Additional Notes
N/A
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]