-
Notifications
You must be signed in to change notification settings - Fork 312
Create a flare contents smoke test #9440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: 2f8c79e | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~2f8c79eb55, baseline=1.53.0-SNAPSHOT~890497c9aa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057285
Total [baseline] (8.631 s) : 0, 8630522
Agent [candidate] (1.045 s) : 0, 1044869
Total [candidate] (8.633 s) : 0, 8632564
section iast
Agent [baseline] (1.178 s) : 0, 1178349
Total [baseline] (9.36 s) : 0, 9360111
Agent [candidate] (1.181 s) : 0, 1181408
Total [candidate] (9.361 s) : 0, 9360604
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~2f8c79eb55, baseline=1.53.0-SNAPSHOT~890497c9aa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (741.505 ms) : 0, 741505
BytebuddyAgent [candidate] (731.23 ms) : 0, 731230
GlobalTracer [baseline] (244.889 ms) : 0, 244889
GlobalTracer [candidate] (242.329 ms) : 0, 242329
AppSec [baseline] (30.635 ms) : 0, 30635
AppSec [candidate] (30.017 ms) : 0, 30017
Debugger [baseline] (6.151 ms) : 0, 6151
Debugger [candidate] (6.051 ms) : 0, 6051
Remote Config [baseline] (682.832 µs) : 0, 683
Remote Config [candidate] (662.084 µs) : 0, 662
Telemetry [baseline] (10.786 ms) : 0, 10786
Telemetry [candidate] (12.162 ms) : 0, 12162
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (850.979 ms) : 0, 850979
BytebuddyAgent [candidate] (853.014 ms) : 0, 853014
GlobalTracer [baseline] (233.45 ms) : 0, 233450
GlobalTracer [candidate] (233.401 ms) : 0, 233401
AppSec [baseline] (26.816 ms) : 0, 26816
AppSec [candidate] (25.01 ms) : 0, 25010
Debugger [baseline] (5.708 ms) : 0, 5708
Debugger [candidate] (5.762 ms) : 0, 5762
Remote Config [baseline] (597.261 µs) : 0, 597
Remote Config [candidate] (596.918 µs) : 0, 597
Telemetry [baseline] (8.202 ms) : 0, 8202
Telemetry [candidate] (8.276 ms) : 0, 8276
IAST [baseline] (30.162 ms) : 0, 30162
IAST [candidate] (32.872 ms) : 0, 32872
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~2f8c79eb55, baseline=1.53.0-SNAPSHOT~890497c9aa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046267
Total [baseline] (10.763 s) : 0, 10763031
Agent [candidate] (1.046 s) : 0, 1045849
Total [candidate] (10.734 s) : 0, 10734078
section appsec
Agent [baseline] (1.229 s) : 0, 1228764
Total [baseline] (10.836 s) : 0, 10835866
Agent [candidate] (1.225 s) : 0, 1224868
Total [candidate] (10.801 s) : 0, 10800915
section iast
Agent [baseline] (1.177 s) : 0, 1176842
Total [baseline] (10.973 s) : 0, 10973120
Agent [candidate] (1.178 s) : 0, 1177602
Total [candidate] (10.911 s) : 0, 10910506
section profiling
Agent [baseline] (1.199 s) : 0, 1198725
Total [baseline] (10.884 s) : 0, 10884056
Agent [candidate] (1.197 s) : 0, 1197481
Total [candidate] (10.881 s) : 0, 10881426
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~2f8c79eb55, baseline=1.53.0-SNAPSHOT~890497c9aa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (732.272 ms) : 0, 732272
BytebuddyAgent [candidate] (731.527 ms) : 0, 731527
GlobalTracer [baseline] (241.94 ms) : 0, 241940
GlobalTracer [candidate] (241.96 ms) : 0, 241960
AppSec [baseline] (30.031 ms) : 0, 30031
AppSec [candidate] (30.189 ms) : 0, 30189
Debugger [baseline] (6.011 ms) : 0, 6011
Debugger [candidate] (6.095 ms) : 0, 6095
Remote Config [baseline] (663.128 µs) : 0, 663
Remote Config [candidate] (673.481 µs) : 0, 673
Telemetry [baseline] (12.842 ms) : 0, 12842
Telemetry [candidate] (13.002 ms) : 0, 13002
section appsec
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (759.478 ms) : 0, 759478
BytebuddyAgent [candidate] (757.641 ms) : 0, 757641
GlobalTracer [baseline] (236.106 ms) : 0, 236106
GlobalTracer [candidate] (234.943 ms) : 0, 234943
AppSec [baseline] (170.871 ms) : 0, 170871
AppSec [candidate] (170.521 ms) : 0, 170521
Debugger [baseline] (5.756 ms) : 0, 5756
Debugger [candidate] (6.525 ms) : 0, 6525
Remote Config [baseline] (634.727 µs) : 0, 635
Remote Config [candidate] (641.781 µs) : 0, 642
Telemetry [baseline] (9.343 ms) : 0, 9343
Telemetry [candidate] (8.475 ms) : 0, 8475
IAST [baseline] (23.918 ms) : 0, 23918
IAST [candidate] (23.52 ms) : 0, 23520
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (849.05 ms) : 0, 849050
BytebuddyAgent [candidate] (849.686 ms) : 0, 849686
GlobalTracer [baseline] (233.622 ms) : 0, 233622
GlobalTracer [candidate] (232.967 ms) : 0, 232967
AppSec [baseline] (27.612 ms) : 0, 27612
AppSec [candidate] (26.59 ms) : 0, 26590
Debugger [baseline] (5.713 ms) : 0, 5713
Debugger [candidate] (5.756 ms) : 0, 5756
Remote Config [baseline] (596.393 µs) : 0, 596
Remote Config [candidate] (590.846 µs) : 0, 591
Telemetry [baseline] (8.266 ms) : 0, 8266
Telemetry [candidate] (8.314 ms) : 0, 8314
IAST [baseline] (29.46 ms) : 0, 29460
IAST [candidate] (31.296 ms) : 0, 31296
section profiling
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (762.195 ms) : 0, 762195
BytebuddyAgent [candidate] (762.746 ms) : 0, 762746
GlobalTracer [baseline] (222.519 ms) : 0, 222519
GlobalTracer [candidate] (222.075 ms) : 0, 222075
AppSec [baseline] (30.135 ms) : 0, 30135
AppSec [candidate] (30.023 ms) : 0, 30023
Debugger [baseline] (6.248 ms) : 0, 6248
Debugger [candidate] (6.288 ms) : 0, 6288
Remote Config [baseline] (714.331 µs) : 0, 714
Remote Config [candidate] (698.065 µs) : 0, 698
Telemetry [baseline] (16.368 ms) : 0, 16368
Telemetry [candidate] (16.429 ms) : 0, 16429
ProfilingAgent [baseline] (108.75 ms) : 0, 108750
ProfilingAgent [candidate] (107.396 ms) : 0, 107396
Profiling [baseline] (109.422 ms) : 0, 109422
Profiling [candidate] (108.041 ms) : 0, 108041
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~2f8c79eb55, baseline=1.53.0-SNAPSHOT~890497c9aa
dateFormat X
axisFormat %s
section baseline
no_agent (4.31 ms) : 4252, 4369
. : milestone, 4310,
iast (9.584 ms) : 9424, 9744
. : milestone, 9584,
iast_FULL (14.675 ms) : 14382, 14969
. : milestone, 14675,
iast_GLOBAL (10.272 ms) : 10080, 10464
. : milestone, 10272,
profiling (8.719 ms) : 8581, 8857
. : milestone, 8719,
tracing (7.422 ms) : 7319, 7526
. : milestone, 7422,
section candidate
no_agent (4.238 ms) : 4192, 4285
. : milestone, 4238,
iast (9.423 ms) : 9264, 9582
. : milestone, 9423,
iast_FULL (13.752 ms) : 13479, 14024
. : milestone, 13752,
iast_GLOBAL (10.386 ms) : 10201, 10571
. : milestone, 10386,
profiling (8.732 ms) : 8589, 8875
. : milestone, 8732,
tracing (7.471 ms) : 7363, 7580
. : milestone, 7471,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~2f8c79eb55, baseline=1.53.0-SNAPSHOT~890497c9aa
dateFormat X
axisFormat %s
section baseline
no_agent (36.721 ms) : 36429, 37012
. : milestone, 36721,
appsec (46.442 ms) : 46022, 46862
. : milestone, 46442,
code_origins (44.397 ms) : 44022, 44772
. : milestone, 44397,
iast (44.383 ms) : 44004, 44763
. : milestone, 44383,
profiling (46.511 ms) : 46055, 46967
. : milestone, 46511,
tracing (43.786 ms) : 43420, 44152
. : milestone, 43786,
section candidate
no_agent (37.832 ms) : 37527, 38138
. : milestone, 37832,
appsec (47.895 ms) : 47476, 48315
. : milestone, 47895,
code_origins (45.158 ms) : 44784, 45531
. : milestone, 45158,
iast (45.356 ms) : 44954, 45759
. : milestone, 45356,
profiling (49.464 ms) : 49014, 49913
. : milestone, 49464,
tracing (45.577 ms) : 45173, 45982
. : milestone, 45577,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~2f8c79eb55, baseline=1.53.0-SNAPSHOT~890497c9aa
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.667 ms) : 3449, 3886
. : milestone, 3667,
iast (2.215 ms) : 2152, 2277
. : milestone, 2215,
iast_GLOBAL (2.261 ms) : 2198, 2325
. : milestone, 2261,
profiling (2.072 ms) : 2021, 2124
. : milestone, 2072,
tracing (2.028 ms) : 1979, 2077
. : milestone, 2028,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.671 ms) : 3453, 3889
. : milestone, 3671,
iast (2.214 ms) : 2151, 2277
. : milestone, 2214,
iast_GLOBAL (2.27 ms) : 2205, 2334
. : milestone, 2270,
profiling (2.06 ms) : 2009, 2111
. : milestone, 2060,
tracing (2.033 ms) : 1984, 2083
. : milestone, 2033,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~2f8c79eb55, baseline=1.53.0-SNAPSHOT~890497c9aa
dateFormat X
axisFormat %s
section baseline
no_agent (15.557 s) : 15557000, 15557000
. : milestone, 15557000,
appsec (15.018 s) : 15018000, 15018000
. : milestone, 15018000,
iast (18.613 s) : 18613000, 18613000
. : milestone, 18613000,
iast_GLOBAL (18.074 s) : 18074000, 18074000
. : milestone, 18074000,
profiling (15.461 s) : 15461000, 15461000
. : milestone, 15461000,
tracing (14.867 s) : 14867000, 14867000
. : milestone, 14867000,
section candidate
no_agent (15.473 s) : 15473000, 15473000
. : milestone, 15473000,
appsec (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
iast (18.109 s) : 18109000, 18109000
. : milestone, 18109000,
iast_GLOBAL (18.266 s) : 18266000, 18266000
. : milestone, 18266000,
profiling (15.975 s) : 15975000, 15975000
. : milestone, 15975000,
tracing (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
|
adb24a8
to
55b00bf
Compare
Squashed 9 commits
90f78ef
to
5f837f1
Compare
dd-smoke-tests/tracer-flare/src/test/groovy/datadog/smoketest/TracerFlareSmokeTest.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make the wait for flare more robust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What Does This Do
This adds a series of smoke test cases which validate flare contents, based on agent configuration and reporters.
Motivation
While hacking on #9433, we noticed that there are currently no tests for the flare functionality (or individual reporters). This aims to remedy the lack of coverage and adhere to our Java LP best practices.
Additional Notes
I don't write much Groovy, so the test could likely be more idiomatic in style.
At the moment, this only tests 2 scenarios:
If this is merged it may make sense to refine the expected & optional filename sets, and to get individual component owners to add new test cases covering their reporter behaviors. Note that this checks for the presence of files, rather than the correctness of file contents / reporter implementations.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROF-12402]