Add new features for trace tagging rules #9131

sezen-datadog · 2025-07-09T10:03:32Z

What Does This Do

Adds trace tagging features in accordance with https://docs.google.com/document/d/1bqDtGgMJgsTW6I16iEcRn1lb9RRQjFRDGim8zRrbs0s/edit?tab=t.0

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APPSEC-57260

sezen-datadog · 2025-07-16T08:08:30Z

dd-java-agent/appsec/src/main/java/com/datadog/appsec/config/AppSecConfigServiceImpl.java

+        case STRING:
+          return reader.nextString();
+        case NUMBER:
+          String numberStr = reader.nextString();


necessary for this part

github-actions · 2025-08-29T07:42:42Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

datadog-datadog-prod-us1 · 2025-08-29T08:48:09Z

🎯 Code Coverage
• Patch Coverage: 75.47%
• Total Coverage: 59.69% (+2.04%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 44c4962 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-29T09:00:03Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sezen.leblay/trace-tagging-rules
git_commit_date	1756820968	1756825911
git_commit_sha	`890497c`	`44c4962`
release_version	1.53.0-SNAPSHOT~890497c9aa	1.53.0-SNAPSHOT~44c4962444

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1756827719	1756827719
ci_job_id	1109178387	1109178387
ci_pipeline_id	75308953	75308953
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-oy2jsoek 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-oy2jsoek 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~44c4962444, baseline=1.53.0-SNAPSHOT~890497c9aa

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047689
Total [baseline] (8.616 s) : 0, 8616402
Agent [candidate] (1.054 s) : 0, 1053998
Total [candidate] (8.63 s) : 0, 8629548
section iast
Agent [baseline] (1.19 s) : 0, 1190057
Total [baseline] (9.408 s) : 0, 9407752
Agent [candidate] (1.203 s) : 0, 1203173
Total [candidate] (9.393 s) : 0, 9392611

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.19 s	142.367 ms (13.6%)
Total	tracing	8.616 s	-
Total	iast	9.408 s	791.35 ms (9.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	iast	1.203 s	149.175 ms (14.2%)
Total	tracing	8.63 s	-
Total	iast	9.393 s	763.063 ms (8.8%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~44c4962444, baseline=1.53.0-SNAPSHOT~890497c9aa

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (732.892 ms) : 0, 732892
BytebuddyAgent [candidate] (737.683 ms) : 0, 737683
GlobalTracer [baseline] (241.99 ms) : 0, 241990
GlobalTracer [candidate] (244.753 ms) : 0, 244753
AppSec [baseline] (30.028 ms) : 0, 30028
AppSec [candidate] (30.528 ms) : 0, 30528
Debugger [baseline] (6.024 ms) : 0, 6024
Debugger [candidate] (6.138 ms) : 0, 6138
Remote Config [baseline] (666.195 µs) : 0, 666
Remote Config [candidate] (680.869 µs) : 0, 681
Telemetry [baseline] (13.676 ms) : 0, 13676
Telemetry [candidate] (11.6 ms) : 0, 11600
section iast
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.492 ms) : 0, 1492
BytebuddyAgent [baseline] (859.682 ms) : 0, 859682
BytebuddyAgent [candidate] (871.293 ms) : 0, 871293
GlobalTracer [baseline] (234.597 ms) : 0, 234597
GlobalTracer [candidate] (235.65 ms) : 0, 235650
AppSec [baseline] (29.507 ms) : 0, 29507
AppSec [candidate] (25.554 ms) : 0, 25554
Debugger [baseline] (5.779 ms) : 0, 5779
Debugger [candidate] (8.479 ms) : 0, 8479
Remote Config [baseline] (619.525 µs) : 0, 620
Remote Config [candidate] (608.686 µs) : 0, 609
Telemetry [baseline] (8.36 ms) : 0, 8360
Telemetry [candidate] (8.252 ms) : 0, 8252
IAST [baseline] (28.867 ms) : 0, 28867
IAST [candidate] (30.418 ms) : 0, 30418

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~44c4962444, baseline=1.53.0-SNAPSHOT~890497c9aa

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049662
Total [baseline] (10.796 s) : 0, 10796312
Agent [candidate] (1.066 s) : 0, 1065608
Total [candidate] (10.701 s) : 0, 10700811
section appsec
Agent [baseline] (1.232 s) : 0, 1232215
Total [baseline] (10.801 s) : 0, 10800626
Agent [candidate] (1.235 s) : 0, 1235397
Total [candidate] (10.904 s) : 0, 10903659
section iast
Agent [baseline] (1.18 s) : 0, 1179947
Total [baseline] (10.979 s) : 0, 10978819
Agent [candidate] (1.191 s) : 0, 1190564
Total [candidate] (10.95 s) : 0, 10950483
section profiling
Agent [baseline] (1.21 s) : 0, 1209771
Total [baseline] (10.911 s) : 0, 10911133
Agent [candidate] (1.198 s) : 0, 1197735
Total [candidate] (10.841 s) : 0, 10841024

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	appsec	1.232 s	182.553 ms (17.4%)
Agent	iast	1.18 s	130.284 ms (12.4%)
Agent	profiling	1.21 s	160.109 ms (15.3%)
Total	tracing	10.796 s	-
Total	appsec	10.801 s	4.314 ms (0.0%)
Total	iast	10.979 s	182.507 ms (1.7%)
Total	profiling	10.911 s	114.821 ms (1.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.066 s	-
Agent	appsec	1.235 s	169.789 ms (15.9%)
Agent	iast	1.191 s	124.956 ms (11.7%)
Agent	profiling	1.198 s	132.127 ms (12.4%)
Total	tracing	10.701 s	-
Total	appsec	10.904 s	202.848 ms (1.9%)
Total	iast	10.95 s	249.672 ms (2.3%)
Total	profiling	10.841 s	140.213 ms (1.3%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~44c4962444, baseline=1.53.0-SNAPSHOT~890497c9aa

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (734.385 ms) : 0, 734385
BytebuddyAgent [candidate] (744.428 ms) : 0, 744428
GlobalTracer [baseline] (242.889 ms) : 0, 242889
GlobalTracer [candidate] (246.469 ms) : 0, 246469
AppSec [baseline] (30.124 ms) : 0, 30124
AppSec [candidate] (30.576 ms) : 0, 30576
Debugger [baseline] (6.04 ms) : 0, 6040
Debugger [candidate] (6.095 ms) : 0, 6095
Remote Config [baseline] (668.195 µs) : 0, 668
Remote Config [candidate] (676.273 µs) : 0, 676
Telemetry [baseline] (12.973 ms) : 0, 12973
Telemetry [candidate] (14.504 ms) : 0, 14504
section appsec
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (761.357 ms) : 0, 761357
BytebuddyAgent [candidate] (766.049 ms) : 0, 766049
GlobalTracer [baseline] (237.371 ms) : 0, 237371
GlobalTracer [candidate] (238.613 ms) : 0, 238613
AppSec [baseline] (171.171 ms) : 0, 171171
AppSec [candidate] (167.145 ms) : 0, 167145
Debugger [baseline] (6.537 ms) : 0, 6537
Debugger [candidate] (6.7 ms) : 0, 6700
Remote Config [baseline] (664.559 µs) : 0, 665
Remote Config [candidate] (648.129 µs) : 0, 648
Telemetry [baseline] (8.592 ms) : 0, 8592
Telemetry [candidate] (9.457 ms) : 0, 9457
IAST [baseline] (23.759 ms) : 0, 23759
IAST [candidate] (23.945 ms) : 0, 23945
section iast
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (851.091 ms) : 0, 851091
BytebuddyAgent [candidate] (859.368 ms) : 0, 859368
GlobalTracer [baseline] (233.458 ms) : 0, 233458
GlobalTracer [candidate] (235.533 ms) : 0, 235533
AppSec [baseline] (28.43 ms) : 0, 28430
AppSec [candidate] (26.496 ms) : 0, 26496
Debugger [baseline] (5.812 ms) : 0, 5812
Debugger [candidate] (6.824 ms) : 0, 6824
Remote Config [baseline] (615.175 µs) : 0, 615
Remote Config [candidate] (612.567 µs) : 0, 613
Telemetry [baseline] (8.436 ms) : 0, 8436
Telemetry [candidate] (8.384 ms) : 0, 8384
IAST [baseline] (29.436 ms) : 0, 29436
IAST [candidate] (30.598 ms) : 0, 30598
section profiling
ProfilingAgent [baseline] (108.959 ms) : 0, 108959
ProfilingAgent [candidate] (107.538 ms) : 0, 107538
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (769.228 ms) : 0, 769228
BytebuddyAgent [candidate] (762.844 ms) : 0, 762844
GlobalTracer [baseline] (225.041 ms) : 0, 225041
GlobalTracer [candidate] (222.271 ms) : 0, 222271
AppSec [baseline] (31.222 ms) : 0, 31222
AppSec [candidate] (30.103 ms) : 0, 30103
Debugger [baseline] (6.383 ms) : 0, 6383
Debugger [candidate] (7.02 ms) : 0, 7020
Remote Config [baseline] (707.537 µs) : 0, 708
Remote Config [candidate] (701.992 µs) : 0, 702
Telemetry [baseline] (15.88 ms) : 0, 15880
Telemetry [candidate] (15.392 ms) : 0, 15392
Profiling [baseline] (109.607 ms) : 0, 109607
Profiling [candidate] (108.211 ms) : 0, 108211

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sezen.leblay/trace-tagging-rules
git_commit_date	1756820968	1756825911
git_commit_sha	`890497c`	`44c4962`
release_version	1.53.0-SNAPSHOT~890497c9aa	1.53.0-SNAPSHOT~44c4962444

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1756827316	1756827316
ci_job_id	1109178388	1109178388
ci_pipeline_id	75308953	75308953
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-8a33jwbr 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-8a33jwbr 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load	better [-327.345µs; -207.429µs] or [-7.190%; -4.556%]	unstable [-68.088op/s; +191.088op/s] or [-6.750%; +18.943%]	4.286ms	1070.250op/s	4.553ms	1008.750op/s
scenario:load:insecure-bank:iast:high_load	worse [+302.041µs; +642.315µs] or [+3.291%; +6.999%]	unstable [-89.601op/s; +40.663op/s] or [-17.719%; +8.041%]	9.649ms	481.219op/s	9.177ms	505.688op/s
scenario:load:petclinic:profiling:high_load	better [-2.407ms; -1.490ms] or [-5.014%; -3.103%]	unstable [-2.923op/s; +11.223op/s] or [-3.000%; +11.517%]	46.059ms	101.600op/s	48.007ms	97.450op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~44c4962444, baseline=1.53.0-SNAPSHOT~890497c9aa
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.553 ms) : 4502, 4604
.   : milestone, 4553,
iast (9.177 ms) : 9026, 9328
.   : milestone, 9177,
iast_FULL (14.03 ms) : 13748, 14313
.   : milestone, 14030,
iast_GLOBAL (10.306 ms) : 10110, 10502
.   : milestone, 10306,
profiling (8.893 ms) : 8754, 9032
.   : milestone, 8893,
tracing (7.476 ms) : 7362, 7590
.   : milestone, 7476,
section candidate
no_agent (4.286 ms) : 4226, 4345
.   : milestone, 4286,
iast (9.649 ms) : 9485, 9814
.   : milestone, 9649,
iast_FULL (14.001 ms) : 13724, 14278
.   : milestone, 14001,
iast_GLOBAL (10.538 ms) : 10353, 10722
.   : milestone, 10538,
profiling (8.847 ms) : 8691, 9003
.   : milestone, 8847,
tracing (7.519 ms) : 7403, 7636
.   : milestone, 7519,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.553 ms [4.502 ms, 4.604 ms]	-
iast	9.177 ms [9.026 ms, 9.328 ms]	4.624 ms (101.6%)
iast_FULL	14.03 ms [13.748 ms, 14.313 ms]	9.477 ms (208.2%)
iast_GLOBAL	10.306 ms [10.11 ms, 10.502 ms]	5.753 ms (126.4%)
profiling	8.893 ms [8.754 ms, 9.032 ms]	4.34 ms (95.3%)
tracing	7.476 ms [7.362 ms, 7.59 ms]	2.923 ms (64.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.286 ms [4.226 ms, 4.345 ms]	-
iast	9.649 ms [9.485 ms, 9.814 ms]	5.364 ms (125.2%)
iast_FULL	14.001 ms [13.724 ms, 14.278 ms]	9.716 ms (226.7%)
iast_GLOBAL	10.538 ms [10.353 ms, 10.722 ms]	6.252 ms (145.9%)
profiling	8.847 ms [8.691 ms, 9.003 ms]	4.561 ms (106.4%)
tracing	7.519 ms [7.403 ms, 7.636 ms]	3.234 ms (75.5%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~44c4962444, baseline=1.53.0-SNAPSHOT~890497c9aa
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.505 ms) : 37196, 37814
.   : milestone, 37505,
appsec (49.472 ms) : 49028, 49915
.   : milestone, 49472,
code_origins (43.573 ms) : 43184, 43962
.   : milestone, 43573,
iast (44.963 ms) : 44576, 45350
.   : milestone, 44963,
profiling (48.007 ms) : 47589, 48425
.   : milestone, 48007,
tracing (44.127 ms) : 43753, 44502
.   : milestone, 44127,
section candidate
no_agent (37.492 ms) : 37181, 37802
.   : milestone, 37492,
appsec (48.421 ms) : 47993, 48850
.   : milestone, 48421,
code_origins (44.784 ms) : 44381, 45188
.   : milestone, 44784,
iast (43.853 ms) : 43468, 44238
.   : milestone, 43853,
profiling (46.059 ms) : 45624, 46493
.   : milestone, 46059,
tracing (45.165 ms) : 44779, 45551
.   : milestone, 45165,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.505 ms [37.196 ms, 37.814 ms]	-
appsec	49.472 ms [49.028 ms, 49.915 ms]	11.966 ms (31.9%)
code_origins	43.573 ms [43.184 ms, 43.962 ms]	6.068 ms (16.2%)
iast	44.963 ms [44.576 ms, 45.35 ms]	7.458 ms (19.9%)
profiling	48.007 ms [47.589 ms, 48.425 ms]	10.502 ms (28.0%)
tracing	44.127 ms [43.753 ms, 44.502 ms]	6.622 ms (17.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.492 ms [37.181 ms, 37.802 ms]	-
appsec	48.421 ms [47.993 ms, 48.85 ms]	10.93 ms (29.2%)
code_origins	44.784 ms [44.381 ms, 45.188 ms]	7.293 ms (19.5%)
iast	43.853 ms [43.468 ms, 44.238 ms]	6.361 ms (17.0%)
profiling	46.059 ms [45.624 ms, 46.493 ms]	8.567 ms (22.8%)
tracing	45.165 ms [44.779 ms, 45.551 ms]	7.673 ms (20.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sezen.leblay/trace-tagging-rules
git_commit_date	1756820968	1756825911
git_commit_sha	`890497c`	`44c4962`
release_version	1.53.0-SNAPSHOT~890497c9aa	1.53.0-SNAPSHOT~44c4962444

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1756827878	1756827878
ci_job_id	1109178389	1109178389
ci_pipeline_id	75308953	75308953
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-a2tq88d8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-a2tq88d8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~44c4962444, baseline=1.53.0-SNAPSHOT~890497c9aa
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.675 ms) : 3452, 3897
.   : milestone, 3675,
iast (2.198 ms) : 2136, 2261
.   : milestone, 2198,
iast_GLOBAL (2.247 ms) : 2184, 2310
.   : milestone, 2247,
profiling (2.05 ms) : 1999, 2101
.   : milestone, 2050,
tracing (2.027 ms) : 1977, 2076
.   : milestone, 2027,
section candidate
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.703 ms) : 3486, 3919
.   : milestone, 3703,
iast (2.204 ms) : 2141, 2267
.   : milestone, 2204,
iast_GLOBAL (2.25 ms) : 2186, 2313
.   : milestone, 2250,
profiling (2.07 ms) : 2018, 2123
.   : milestone, 2070,
tracing (2.023 ms) : 1974, 2072
.   : milestone, 2023,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.486 ms]	-
appsec	3.675 ms [3.452 ms, 3.897 ms]	2.2 ms (149.2%)
iast	2.198 ms [2.136 ms, 2.261 ms]	723.608 µs (49.1%)
iast_GLOBAL	2.247 ms [2.184 ms, 2.31 ms]	772.722 µs (52.4%)
profiling	2.05 ms [1.999 ms, 2.101 ms]	575.292 µs (39.0%)
tracing	2.027 ms [1.977 ms, 2.076 ms]	552.285 µs (37.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.486 ms]	-
appsec	3.703 ms [3.486 ms, 3.919 ms]	2.228 ms (151.1%)
iast	2.204 ms [2.141 ms, 2.267 ms]	729.541 µs (49.5%)
iast_GLOBAL	2.25 ms [2.186 ms, 2.313 ms]	774.844 µs (52.5%)
profiling	2.07 ms [2.018 ms, 2.123 ms]	595.555 µs (40.4%)
tracing	2.023 ms [1.974 ms, 2.072 ms]	548.142 µs (37.2%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~44c4962444, baseline=1.53.0-SNAPSHOT~890497c9aa
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.513 s) : 15513000, 15513000
.   : milestone, 15513000,
appsec (14.779 s) : 14779000, 14779000
.   : milestone, 14779000,
iast (18.742 s) : 18742000, 18742000
.   : milestone, 18742000,
iast_GLOBAL (17.862 s) : 17862000, 17862000
.   : milestone, 17862000,
profiling (15.984 s) : 15984000, 15984000
.   : milestone, 15984000,
tracing (14.882 s) : 14882000, 14882000
.   : milestone, 14882000,
section candidate
no_agent (14.969 s) : 14969000, 14969000
.   : milestone, 14969000,
appsec (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
iast (18.885 s) : 18885000, 18885000
.   : milestone, 18885000,
iast_GLOBAL (18.127 s) : 18127000, 18127000
.   : milestone, 18127000,
profiling (15.447 s) : 15447000, 15447000
.   : milestone, 15447000,
tracing (15.118 s) : 15118000, 15118000
.   : milestone, 15118000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.513 s [15.513 s, 15.513 s]	-
appsec	14.779 s [14.779 s, 14.779 s]	-734.0 ms (-4.7%)
iast	18.742 s [18.742 s, 18.742 s]	3.229 s (20.8%)
iast_GLOBAL	17.862 s [17.862 s, 17.862 s]	2.349 s (15.1%)
profiling	15.984 s [15.984 s, 15.984 s]	471.0 ms (3.0%)
tracing	14.882 s [14.882 s, 14.882 s]	-631.0 ms (-4.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.969 s [14.969 s, 14.969 s]	-
appsec	15.022 s [15.022 s, 15.022 s]	53.0 ms (0.4%)
iast	18.885 s [18.885 s, 18.885 s]	3.916 s (26.2%)
iast_GLOBAL	18.127 s [18.127 s, 18.127 s]	3.158 s (21.1%)
profiling	15.447 s [15.447 s, 15.447 s]	478.0 ms (3.2%)
tracing	15.118 s [15.118 s, 15.118 s]	149.0 ms (1.0%)

dd-java-agent/appsec/src/main/java/com/datadog/appsec/config/AppSecConfigServiceImpl.java

AlexeyKuznetsov-DD · 2025-08-29T14:21:42Z

dd-java-agent/appsec/src/main/java/com/datadog/appsec/gateway/AppSecRequestContext.java

+    try {
+      // Check if it contains a decimal point to determine if it's a double
+      if (value.contains(".")) {
+        return Double.parseDouble(value);
+      } else {
+        // Try to parse as integer first
+        return Long.parseLong(value);
+      }
+    } catch (NumberFormatException e) {
+      return null;
+    }


I can similar code 2 times in this PR.
Can it be refactored to some utility function?

Signed-off-by: sezen.leblay <[email protected]>

sezen-datadog force-pushed the sezen.leblay/trace-tagging-rules branch 23 times, most recently from ee7db66 to b6e4650 Compare July 15, 2025 14:33

sezen-datadog commented Jul 16, 2025

View reviewed changes

sezen-datadog force-pushed the sezen.leblay/trace-tagging-rules branch 6 times, most recently from 5ca7317 to 5ef6358 Compare July 16, 2025 11:23

sezen-datadog force-pushed the sezen.leblay/trace-tagging-rules branch from 5ef6358 to e6718ae Compare August 29, 2025 07:39

sezen-datadog marked this pull request as ready for review August 29, 2025 07:42

sezen-datadog requested review from a team as code owners August 29, 2025 07:42

sezen-datadog requested review from smola, jandro996 and AlexeyKuznetsov-DD and removed request for a team August 29, 2025 07:42

sezen-datadog force-pushed the sezen.leblay/trace-tagging-rules branch 2 times, most recently from 9ad3778 to e83bb0f Compare August 29, 2025 08:25

sezen-datadog added comp: asm waf Application Security Management (WAF) type: enhancement Enhancements and improvements labels Aug 29, 2025

AlexeyKuznetsov-DD reviewed Aug 29, 2025

View reviewed changes

dd-java-agent/appsec/src/main/java/com/datadog/appsec/config/AppSecConfigServiceImpl.java Outdated Show resolved Hide resolved

AlexeyKuznetsov-DD reviewed Aug 29, 2025

View reviewed changes

sezen-datadog force-pushed the sezen.leblay/trace-tagging-rules branch 5 times, most recently from c600940 to ebc5973 Compare September 2, 2025 15:11

Add new features for trace tagging rules

44c4962

Signed-off-by: sezen.leblay <[email protected]>

sezen-datadog force-pushed the sezen.leblay/trace-tagging-rules branch from ebc5973 to 44c4962 Compare September 2, 2025 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add new features for trace tagging rules #9131

Add new features for trace tagging rules #9131

Uh oh!

sezen-datadog commented Jul 9, 2025 •

edited by jira bot

Loading

Uh oh!

sezen-datadog Jul 16, 2025

Uh oh!

github-actions bot commented Aug 29, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 29, 2025 •

edited by datadog-official bot

Loading

Uh oh!

pr-commenter bot commented Aug 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

AlexeyKuznetsov-DD Aug 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Add new features for trace tagging rules #9131

Are you sure you want to change the base?

Add new features for trace tagging rules #9131

Uh oh!

Conversation

sezen-datadog commented Jul 9, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

sezen-datadog Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 29, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

AlexeyKuznetsov-DD Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sezen-datadog commented Jul 9, 2025 •

edited by jira bot

Loading

github-actions bot commented Aug 29, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Aug 29, 2025 •

edited by datadog-official bot

Loading

pr-commenter bot commented Aug 29, 2025 •

edited

Loading

AlexeyKuznetsov-DD Aug 29, 2025 •

edited

Loading