Skip to content

Conversation

@ysk24ok
Copy link

@ysk24ok ysk24ok commented Jan 1, 2026

What does this PR do?

Adding db.instance field to Valkey spans.

Motivation

This is to align with inferred services. Without this, peer.hostname field (in a k8s environment the value is a pod name) and cardinality is too high.
db.name takes precedence over db.instance but in case of Valkey I was not sure what db.name represented so I chose db.instance.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@ysk24ok ysk24ok requested review from a team as code owners January 1, 2026 08:36
Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for APM LP Go, but I relay on IDM approval.

@ysk24ok ysk24ok changed the title valkey-go: Add db.instance to Valkey spans chore(contrib/valkey-io/valkey-go): Add db.instance to Valkey spans Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants