Skip to content

Conversation

@e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Dec 22, 2025

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Dec 22, 2025
@datadog-official
Copy link
Contributor

datadog-official bot commented Dec 22, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: da67f3d | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.70%. Comparing base (886ce05) to head (da67f3d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
instrumentation/httptrace/resource_renaming.go 61.90% 8 Missing ⚠️
instrumentation/httptrace/before_handle.go 75.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
instrumentation/httptrace/before_handle.go 84.00% <75.00%> (-2.45%) ⬇️
instrumentation/httptrace/resource_renaming.go 61.90% <61.90%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Dec 22, 2025

Benchmarks

Benchmark execution time: 2025-12-22 14:17:27

Comparing candidate commit da67f3d in PR branch flavien/resource-renaming-contribs with baseline commit e744f8a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 0 unstable metrics.

@e-n-0 e-n-0 force-pushed the flavien/resource-renaming-contribs branch from d51bade to da67f3d Compare December 22, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants