Skip to content

Conversation

@igoragoli
Copy link
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2025

Benchmarks

Benchmark execution time: 2025-12-24 14:12:37

Comparing candidate commit 24ee1aa in PR branch augusto/add-twmb-franz-go-integration with baseline commit cb0d2a1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 0 unstable metrics.

@igoragoli igoragoli force-pushed the augusto/add-twmb-franz-go-integration branch from 53976be to 1d2f77e Compare December 18, 2025 14:28
@datadog-official
Copy link
Contributor

datadog-official bot commented Dec 18, 2025

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 3 Tests failed

TestConsumeFunctional from github.com/DataDog/dd-trace-go/contrib/twmb/franz-go/v2 (Datadog) (Fix with Cursor)
Failed

=== RUN   TestConsumeFunctional
    kgo_test.go:249: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/twmb/franz-go/kgo_test.go:249
        	Error:      	"[0xc00038ba40 0xc00038bb80 0xc00038bcc0]" should have 1 item(s), but has 3
        	Test:       	TestConsumeFunctional
--- FAIL: TestConsumeFunctional (0.06s)

    TestIntegrationEnabled from github.com/DataDog/dd-trace-go/v2/instrumentation (Fix with Cursor)

TestTelemetryEnabled from github.com/DataDog/dd-trace-go/v2/instrumentation/internal/telemetrytest (Datadog) (Fix with Cursor)
Failed

=== RUN   TestTelemetryEnabled
    telemetry_test.go:52: D:\a\dd-trace-go\dd-trace-go\contrib\99designs\gqlgen
    telemetry_test.go:52: D:\a\dd-trace-go\dd-trace-go\contrib\IBM\sarama
    telemetry_test.go:52: D:\a\dd-trace-go\dd-trace-go\contrib\Shopify\sarama
    telemetry_test.go:52: D:\a\dd-trace-go\dd-trace-go\contrib\aws\aws-sdk-go
    telemetry_test.go:52: D:\a\dd-trace-go\dd-trace-go\contrib\aws\aws-sdk-go-v2
    telemetry_test.go:52: D:\a\dd-trace-go\dd-trace-go\contrib\aws\datadog-lambda-go
    telemetry_test.go:52: D:\a\dd-trace-go\dd-trace-go\contrib\bradfitz\gomemcache
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 24ee1aa | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 30.43478% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.84%. Comparing base (4a796cc) to head (24ee1aa).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
contrib/twmb/franz-go/internal/tracing/carrier.go 0.00% 23 Missing ⚠️
contrib/twmb/franz-go/internal/tracing/options.go 60.86% 7 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
instrumentation/packages.go 9.23% <ø> (ø)
contrib/twmb/franz-go/internal/tracing/options.go 60.86% <60.86%> (ø)
contrib/twmb/franz-go/internal/tracing/carrier.go 0.00% <0.00%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants