output supported versions #3058

quinna-h · 2024-12-24T15:32:18Z

What does this PR do?

Runs the script .github/workflows/apps/output_integration_versions.go
- This uses the minimum version stated in the integration_go.mod, and the maximum from go list -m -versions <package>
Adds the Supported Versions workflow which runs only after Smoke Tests successfully passes on main
- This is since Smoke Tests tests that ddtrace works with the latest versions of the packages. So if Smoke Tests passed, we can safely assume that latest works.

TODO:

Change the workflow to not be tied to just Smoke Tests (we don't necessarily want it to run after every successful Smoke Tests run on main, as this would run several times a day).
Consider mapping repositories -> package name

Motivation

Reviewer's Checklist

Changed code has unit tests for its functionality at or near 100% coverage.
System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
There is a benchmark for any new code, or changes to existing code.
If this interacts with the agent in a new way, a system test has been added.
Add an appropriate team label so this PR gets put in the right place for the release notes.
Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

datadog-datadog-prod-us1 · 2024-12-24T15:32:54Z

.github/workflows/supported-versions.yml

+      # note: This will only run when there *are* changes to integration versions
+      - name: Create Pull Request
+        id: pr
+        uses: peter-evans/create-pull-request@v6


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

datadog-datadog-prod-us1 · 2024-12-24T15:32:54Z

.github/workflows/supported-versions.yml

+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
+    steps:
+      - uses: actions/checkout@v4


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

datadog-datadog-prod-us1 · 2024-12-24T15:32:54Z

.github/workflows/supported-versions.yml

@@ -0,0 +1,44 @@
+name: Supported Versions
+on:
+    workflow_run:


🟠 Code Vulnerability

Dangerous GitHub actions trigger (...read more)

datadog-datadog-prod-us1 · 2024-12-24T15:38:41Z

Datadog Report

Branch report: quinna/add-supported-versions-workflow
Commit report: db12b3e
Test service: dd-trace-go

✅ 0 Failed, 5121 Passed, 70 Skipped, 2m 54.95s Total Time

pr-commenter · 2024-12-24T16:15:44Z

Benchmarks

Benchmark execution time: 2025-01-03 18:12:55

Comparing candidate commit 26b5d26 in PR branch quinna/add-supported-versions-workflow with baseline commit d393324 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

quinna-h · 2024-12-27T00:03:15Z

.github/workflows/apps/output_integration_versions.go

+func main() {
+	goModPath := "integration_go.mod" // path to integration_go.mod
+	outputPath := "supported_versions.md"
+	instrumentedSet := map[string]struct{}{


This is from https://github.com/DataDog/orchestrion?tab=readme-ov-file#supported-libraries

quinna-h · 2025-01-02T15:20:06Z

integration_go.mod

@@ -42,15 +42,13 @@ require (
 	github.com/gocql/gocql v1.6.0     
 	github.com/gofiber/fiber/v2 v2.52.5
 	github.com/gomodule/redigo v1.8.9     
-	github.com/google/pprof v0.0.0-20230817174616-7a8ec2ada47b


Probably put these changes in a separate PR

rarguelloF

The generated format looks good! I pointed out some problems / wrong info I see in the outputted markdown.

rarguelloF · 2025-01-03T12:17:11Z

supported_versions.md

+| github.com/go-redis/redis | v6.15.9+incompatible | v6.15.9+incompatible | false
+| github.com/go-redis/redis/v7 | v7.4.1 | v7.4.1 | true
+| github.com/go-redis/redis/v8 | v8.11.5 | v8.11.5 | true
+| github.com/go-redis/redis/v9 | v9.7.0   // renamed to redis/go-redis in v9 | v9.7.0 | false


rarguelloF · 2025-01-03T12:17:29Z

supported_versions.md

+| github.com/emicklei/go-restful/v3 | v3.11.0 | v3.12.1 | false
+| github.com/garyburd/redigo | v1.6.4 | v1.6.4 | false
+| github.com/gin-gonic/gin | v1.9.1 | v1.10.0 | true
+| github.com/globalsign/mgo | v0.0.0-20181015135952-eeefdecb41b8 | github.com/globalsign/mgo | false


third column doesn't contain a version

rarguelloF · 2025-01-03T12:17:49Z

supported_versions.md

+| github.com/bradfitz/gomemcache | v0.0.0-20230611145640-acc696258285 | github.com/bradfitz/gomemcache | false
+| github.com/confluentinc/confluent-kafka-go | v1.9.2 | v1.9.3-RC3 | false
+| github.com/confluentinc/confluent-kafka-go/v2 | v2.2.0 | v2.6.1 | false
+| github.com/denisenkom/go-mssqldb | v0.11.0 | v0.12.3 | false


this is not an integration

marking the subsequent related comments as resolved, addressed these in #3064

rarguelloF · 2025-01-03T12:18:11Z

supported_versions.md

+| github.com/aws/aws-sdk-go-v2/service/sfn | v1.19.4 | v1.34.2 | false
+| github.com/aws/aws-sdk-go-v2/service/sns | v1.21.4 | v1.33.8 | false
+| github.com/aws/aws-sdk-go-v2/service/sqs | v1.24.4 | v1.37.3 | false
+| github.com/bradfitz/gomemcache | v0.0.0-20230611145640-acc696258285 | github.com/bradfitz/gomemcache | false


third column does not contain a version

supported_versions.md

rarguelloF · 2025-01-03T12:35:24Z

integration_go.mod

 	github.com/google/uuid v1.5.0
 	github.com/gorilla/mux v1.8.0     
 	github.com/graph-gophers/graphql-go v1.5.0     
 	github.com/graphql-go/graphql v0.8.1     
 	github.com/graphql-go/handler v0.2.3
 	github.com/hashicorp/consul/api v1.24.0     
 	github.com/hashicorp/go-multierror v1.1.1
-	github.com/hashicorp/go-secure-stdlib/parseutil v0.1.7
 	github.com/hashicorp/vault/api v1.9.2
 	github.com/hashicorp/vault/sdk v0.9.2
 	github.com/jackc/pgx/v5 v5.6.0     


How is this go.mod being generated?

quinna-h added 2 commits December 24, 2024 10:30

wip

954feea

add table

6613235

datadog-datadog-prod-us1 bot reviewed Dec 24, 2024

View reviewed changes

quinna-h added 2 commits December 26, 2024 13:40

remove non-contrib packages and add aut-instrumented

5583f81

wip

827f52f

quinna-h commented Dec 27, 2024

View reviewed changes

quinna-h commented Jan 2, 2025

View reviewed changes

quinna-h requested a review from rarguelloF January 2, 2025 15:20

rarguelloF requested changes Jan 3, 2025

View reviewed changes

update logic

26b5d26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

output supported versions #3058

output supported versions #3058

quinna-h commented Dec 24, 2024 •

edited

Loading

datadog-datadog-prod-us1 bot Dec 24, 2024

datadog-datadog-prod-us1 bot Dec 24, 2024

datadog-datadog-prod-us1 bot Dec 24, 2024

datadog-datadog-prod-us1 bot commented Dec 24, 2024 •

edited

Loading

pr-commenter bot commented Dec 24, 2024 •

edited

Loading

quinna-h Dec 27, 2024

quinna-h Jan 2, 2025

rarguelloF left a comment

rarguelloF Jan 3, 2025

rarguelloF Jan 3, 2025

rarguelloF Jan 3, 2025

quinna-h Jan 3, 2025 •

edited

Loading

rarguelloF Jan 3, 2025

rarguelloF Jan 3, 2025

	\| github.com/go-redis/redis/v9 \| v9.7.0 // renamed to redis/go-redis in v9 \| v9.7.0 \| false
	\| github.com/redis/go-redis/v9 \| v9.7.0 \| v9.7.0 \| false

output supported versions #3058

Are you sure you want to change the base?

output supported versions #3058

Conversation

quinna-h commented Dec 24, 2024 • edited Loading

What does this PR do?

Motivation

Reviewer's Checklist

datadog-datadog-prod-us1 bot Dec 24, 2024

Choose a reason for hiding this comment

🟠 Code Vulnerability

datadog-datadog-prod-us1 bot Dec 24, 2024

Choose a reason for hiding this comment

🟠 Code Vulnerability

datadog-datadog-prod-us1 bot Dec 24, 2024

Choose a reason for hiding this comment

🟠 Code Vulnerability

datadog-datadog-prod-us1 bot commented Dec 24, 2024 • edited Loading

Datadog Report

pr-commenter bot commented Dec 24, 2024 • edited Loading

Benchmarks

quinna-h Dec 27, 2024

Choose a reason for hiding this comment

quinna-h Jan 2, 2025

Choose a reason for hiding this comment

rarguelloF left a comment

Choose a reason for hiding this comment

rarguelloF Jan 3, 2025

Choose a reason for hiding this comment

rarguelloF Jan 3, 2025

Choose a reason for hiding this comment

rarguelloF Jan 3, 2025

Choose a reason for hiding this comment

quinna-h Jan 3, 2025 • edited Loading

Choose a reason for hiding this comment

rarguelloF Jan 3, 2025

Choose a reason for hiding this comment

rarguelloF Jan 3, 2025

Choose a reason for hiding this comment

quinna-h commented Dec 24, 2024 •

edited

Loading

datadog-datadog-prod-us1 bot commented Dec 24, 2024 •

edited

Loading

pr-commenter bot commented Dec 24, 2024 •

edited

Loading

quinna-h Jan 3, 2025 •

edited

Loading