fix(ddtrace/tracer): avoid tests to fail with error "non-constant format string" from upcoming Go 1.24 release #3048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upcoming Go 1.24 release introduces a new
go vet
check (golang/go#60529) for printf calls with non-const format and no args. This causesgo test
to fail to run ingotip
:We decided to strategically modify all logging statements, after trying refactoring
internal/log
API to offer:Debug
,Info
,Warn
,Error
functions for logging a string without argumentsDebugf
,Infof
,Warnf
,Errorf
function for logging formatted messages with argumentsThis caused a significant amount of changes across the repository, but we want to keep the API as coherent as possible. It mirrors stdlib's
log
API.Motivation
Avoid unintended consequences from upcoming Go 1.24 release.
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!