v2: remove deprecated samplingpriority #2890
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove support for the
SamplingPriority
constant, which was deprecated in PR #1082. Replace instances withManualKeep
andManualDrop
.SamplingPriority
of either1
or2
. They should now usesamplingDecision = 2
to indicate they should be kept.SamplingPriority
0
or-1
. Now, it has valuesamplingDecision=1
Motivation
For v2 release, we should remove support for deprecated constants and functions, especially those that have been deprecated for many, subsequent minor versions.
Reviewer's Checklist
Unsure? Have a question? Request a review!