internal/globalconfig: make statsTags un-changeable from outside of the globalconfig package #2842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
globalconfig.SetStatsTags(tags []string)
now makes a copy oftags
before setting it as the value ofcfg.statsTags
globalconfig.StatsTags()
now returns a copy ofcfg.statsTags
Motivation
Failure to perform the copying specified above resulted in pollution of the globalconfig statsTags.
#2836
Reviewer's Checklist
Unsure? Have a question? Request a review!