ci: set GOTOOLCHAIN=local for unit tests #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsrip-dd
force-pushed
the
nick.ripley/gotoolchain
branch
from
a8be066 to
e153884
Compare
Users may build our library with GOTOOLCHAIN=local. If they do, and our go.mod file specifies a newer Go version than their local toolchain, their build will break. Run our tests with GOTOOLCHAIN=local to ensure that our library builds with all of the Go versions we claim to support, without having to download a newer one.
nsrip-dd
force-pushed
the
nick.ripley/gotoolchain
branch
from
e153884 to
e39271d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set
GOTOOLCHAIN=localfor our unit tests.I didn't change the
go get -usmoke tests. Those tests are inherentlyincompatible with
GOTOOLCHAIN=local. We could perhaps make themwork with
GOTOOLCHAIN=localby adding[email protected]to thego get -ucommands, like Orhcestrion does.
Motivation
Users may build our library with
GOTOOLCHAIN=local. If they do, and ourgo.mod file specifies a newer Go version than their local toolchain, their
build will break. Run our tests with
GOTOOLCHAIN=localto ensure thatour library builds with all of the Go versions we claim to support,
without having to download a newer one.