-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/tracer: add IsTraceRoot to clients-side-stats #2821
Conversation
BenchmarksBenchmark execution time: 2024-08-21 16:54:45 Comparing candidate commit 2055b50 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 1 unstable metrics. scenario:BenchmarkInjectW3C-24
|
const ( | ||
trilean_not_set trilean = iota | ||
trilean_true | ||
trilean_false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixge You are right, I didn't notice it. The trilean concept blinded me. We'll merge to improve this.
What does this PR do?
This PR adds the IsTraceRoot field to client stats payloads.
Motivation
In order to support adaptive sampling, we want to make this small change to the existing client stats implementation to bring it up to date with the version in the Trace Agent.
See:
DataDog/datadog-agent#23302
DataDog/datadog-agent#25374
Reviewer's Checklist
Unsure? Have a question? Request a review!