Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtracer/tracer: fix appending 'tracer_version' to the statsd tags #2801

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

nsrip-dd
Copy link
Contributor

What does this PR do?

Cherry-picks #2784 from release-v1.66.x to main. That PR fixed the tracer's
statsd configuration to properly tag internal metrics with the tracer version.

Motivation

We use these metrics to track release candidate behavior for internal services
during release dogfooding.

@nsrip-dd nsrip-dd marked this pull request as ready for review July 29, 2024 17:57
@nsrip-dd nsrip-dd requested a review from a team as a code owner July 29, 2024 17:57
@pr-commenter
Copy link

pr-commenter bot commented Jul 29, 2024

Benchmarks

Benchmark execution time: 2024-07-29 18:18:09

Comparing candidate commit 24e74ed in PR branch nick.ripley/statsd-tracer-version with baseline commit 70fa492 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics.

@nsrip-dd nsrip-dd merged commit f8a22c3 into main Jul 29, 2024
164 checks passed
@nsrip-dd nsrip-dd deleted the nick.ripley/statsd-tracer-version branch July 29, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants