-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/opentelemetry: add RWMutex to handle concurrent calls to setters #2521
ddtrace/opentelemetry: add RWMutex to handle concurrent calls to setters #2521
Conversation
a3c3459
to
31e9e44
Compare
BenchmarksBenchmark execution time: 2024-01-26 19:24:26 Comparing candidate commit d4bb929 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
…x-concurrent-setattributes
The changes look good to me, so I'll approve them. However, I made a couple of commits, so I'd like @dianashevchenko to look this over on Monday. |
Thanks @katiehockman & @dianashevchenko! |
What does this PR do?
Fixes #2518.
Motivation
Making sure OTel spans can be used concurrently, as our
tracer.Span
.Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!