-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft; don't merge] v2.0.0-rc #2427
base: main
Are you sure you want to change the base?
Conversation
BenchmarksBenchmark execution time: 2025-01-03 15:41:44 Comparing candidate commit 50298b9 in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 1 performance improvements and 11 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. scenario:BenchmarkHttpServeTrace-24
scenario:BenchmarkInjectW3C-24
scenario:BenchmarkPartialFlushing/Disabled-24
scenario:BenchmarkPartialFlushing/Enabled-24
scenario:BenchmarkSetTagString-24
scenario:BenchmarkSingleSpanRetention/no-rules-24
scenario:BenchmarkSingleSpanRetention/with-rules/match-all-24
scenario:BenchmarkSingleSpanRetention/with-rules/match-half-24
scenario:BenchmarkStartSpan-24
scenario:BenchmarkTracerAddSpans-24
|
…ations pattern for default start span options in contribs
Magic command: find . -type f -name go.mod | while read f; do cd $(dirname $f) && go1.19.13 get github.com/DataDog/dd-trace-go/v2@v2-dev && (grep "/v2/contrib" go.mod | grep -v module | cut -f1 -d' ' | sed 's/\t//g' | xargs -I {} go1.19.13 get {}@v2-dev) && go1.19.13 mod tidy && cd -; done
…or v2 release script
Signed-off-by: Eliott Bouhana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…stTraceWriterFlushRetries
…3033) Signed-off-by: Eliott Bouhana <[email protected]>
What does this PR do?
This PR is a preview of the changes that will be merged into main for v2 release as
github.com/DataDog/dd-trace-go/v2
.Motivation
These are the main motivations behind releasing a v2:
gopkg.in
: this causes pain in enterprise customers.Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!