suggestions from @Julio-Guerra

Signed-off-by: Eliott Bouhana <[email protected]>
DataDog · Dec 19, 2024 · 2be912c · 2be912c
1 parent d400974
commit 2be912c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/ddtrace/tracer/tracer.go b/ddtrace/tracer/tracer.go
@@ -737,6 +737,7 @@ func (t *tracer) Inject(ctx ddtrace.SpanContext, carrier interface{}) error {
 
 	if t.config.tracingAsTransport {
 		// in tracing as transport mode, only propagate when there is an upstream appsec event
+		// TODO: replace with _dd.p.ts in the next iteration standardizing this for other products, comparing enabled products in `t.config` with their corresponding `_dd.p.ts` bitfields
 		if ctx, ok := ctx.(*spanContext); ok && ctx.trace != nil && ctx.trace.propagatingTag("_dd.p.appsec") != "1" {
 			return nil
 		}
@@ -784,6 +785,7 @@ func (t *tracer) Extract(carrier interface{}) (ddtrace.SpanContext, error) {
 	ctx, err := t.config.propagator.Extract(carrier)
 	if t.config.tracingAsTransport {
 		// in tracing as transport mode, reset upstream sampling decision to make sure we keep 1 trace/minute
+		// TODO: replace with _dd.p.ts in the next iteration standardizing this for other products, comparing enabled products in `t.config` with their corresponding `_dd.p.ts` bitfields
 		if ctx, ok := ctx.(*spanContext); ok && ctx.trace.propagatingTag("_dd.p.appsec") != "1" {
 			ctx.trace.priority = nil
 		}

diff --git a/internal/appsec/listener/waf/waf.go b/internal/appsec/listener/waf/waf.go
@@ -89,18 +89,18 @@ func (waf *Feature) onStart(op *waf.ContextOperation, _ waf.ContextArgs) {
 
 func (*Feature) SetupActionHandlers(op *waf.ContextOperation) {
 	// Set the blocking tag on the operation when a blocking event is received
-	dyngo.OnData(op, func(_ *events.BlockingSecurityEvent) {
+	dyngo.OnData(op, func(*events.BlockingSecurityEvent) {
 		log.Debug("appsec: blocking event detected")
 		op.SetTag(BlockedRequestTag, true)
 	})
 
 	// Register the stacktrace if one is requested by a WAF action
-	dyngo.OnData(op, func(err *actions.StackTraceAction) {
+	dyngo.OnData(op, func(action *actions.StackTraceAction) {
 		log.Debug("appsec: registering stack trace for security purposes")
-		op.AddStackTraces(err.Event)
+		op.AddStackTraces(action.Event)
 	})
 
-	dyngo.OnData(op, func(_ *waf.SecurityEvent) {
+	dyngo.OnData(op, func(*waf.SecurityEvent) {
 		log.Debug("appsec: WAF detected a suspicious event")
 		SetEventSpanTags(op)
 	})