-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cardinality common field #883
base: master
Are you sure you want to change the base?
Add Cardinality common field #883
Conversation
4f4fc36
to
a31858a
Compare
39739aa
to
561c672
Compare
9bfa236
to
25d7aec
Compare
25d7aec
to
648d06d
Compare
@@ -1343,6 +1380,8 @@ def event( | |||
string = "%s|#%s" % (string, ",".join(tags)) | |||
if self._container_id: | |||
string = "%s|c:%s" % (string, self._container_id) | |||
if cardinality: | |||
string = "%s|card:%s" % (string, cardinality) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
648d06d
to
76181c4
Compare
d3b3d72
to
324c61b
Compare
324c61b
to
34e626f
Compare
What happens when this is used with an Agent version that doesn't have support for the structured |
34e626f
to
d8b986e
Compare
d8b986e
to
09092f1
Compare
Hey @tobz 👋 The Agent will simply discard the unknown common field and the Agent cardinality ( |
09092f1
to
99bdf37
Compare
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
|
||
:param cardinality: Set the global cardinality for all metrics. \ | ||
Possible values are "none", "low", "orchestrator" and "high". | ||
Can also be set via the DATADOG_CARDINALITY or DD_CARDINALITY environment variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link to possible values to the tag cardinality section in our docs with something like to "to see all possible values check our docs"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say we are good as all the values are in the comment 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed together as it would be better to also include documentation in case of value changes in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly adding the link would break the linter.
99bdf37
to
5a79ab8
Compare
Signed-off-by: Wassim DHIF <[email protected]>
5a79ab8
to
8c2f1fc
Compare
What does this PR do?
Implement the
card:
common field to DogStatsD Datagram spec. This new field is used to override the Agent cardinality.Description of the Change
Adds a new cardinality setting that can be either:
This settings is then send as the
card:
common field.Alternate Designs
Possible Drawbacks
None
Verification Process
Unit tests have been implemented to test the feature. QA has been done manually and can be found in DataDog/datadog-agent#32917.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.