-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extended aggregation #863
Open
andrewqian2001datadog
wants to merge
47
commits into
master
Choose a base branch
from
add-extended-aggregation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add buffered_metrics object type * update metric_types to include histogram, distribution, timing * Run tests on any branch
…py into add-extended-aggregation
def should_sample(self, rate): | ||
"""Determine if a sample should be kept based on the specified rate.""" | ||
with self.random_lock: | ||
return self.random.random() < rate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Vulnerability
do not use random (...read more)
Make sure to use values that are actually random. The random
module in Python should generally not be used and replaced with the secrets
module, as noted in the official Python documentation.
Learn More
…are just buffered
andrewqian2001datadog
added
the
changelog/Added
Added features results into a minor version bump
label
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Implements aggregation for histogram, distribution and timing metrics. This is essentially just buffering as these metrics should not be aggregated in the client side (From the V2 section of the design doc, "Both metrics can’t/should not be aggregated on the client side. Histogram would result in wrong metrics and merging distributions is costly while sampling is fast").
This is already implemented for the go client. Go Client PR for adding extended aggregation
Description of the Change
This PR reuses a lot of the existing buffering logic. The buffered_metrics (Histogram, Distribution and Timing) are added to the existing buffer when aggregation is enabled.
Most of the new logic is in
buffered_metric_context.py
which involves sampling Histograms, Distributions and TimingsVerification Process
Follow steps here to set up local testing for the python client
Replace
testapp/main.py
withSearch for your metric name in the metrics explorer and verify values are as expected.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.