Skip to content

Conversation

@swang392
Copy link
Contributor

@swang392 swang392 commented Jan 23, 2026

What does this PR do?

  • 625e12f: Add multiple provider node labels for EKS
  • a8311c3 and 9c688aa: fix bug where agent daemonsets didn't get scheduled when nodes had different provider node labels

Motivation

https://datadoghq.atlassian.net/browse/AGENTONB-2839
https://datadoghq.atlassian.net/browse/AGENTONB-2840

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

tested locally against the erroring case from support case

  • create a kind cluster
  • label each node with a different EKS label:
k label nodes swang392-migration-worker3 alpha.eksctl.io/cluster-name=fargate
k label nodes swang392-migration-control-plane eks.amazonaws.com/compute-type=test
k label nodes swang392-migration-worker eks.amazonaws.com/nodegroup-image=ami-sdfasdfasdfsd
k label nodes swang392-migration-worker2 eks.amazonaws.com/nodegroup=asdkfjasdhf
  • Deploy operator with DDAI disabled and introspection enabled
  • Check that the provider detected is EKS:
{"level":"DEBUG","ts":"2026-01-23T21:36:25.590Z","logger":"controllers.DatadogAgent","msg":"New provider detected","datadogagent":{"name":"datadog","namespace":"system"},"provider":"eks"}
{"level":"DEBUG","ts":"2026-01-23T21:36:25.591Z","logger":"controllers.DatadogAgent","msg":"New provider detected","datadogagent":{"name":"datadog","namespace":"system"},"provider":"eks"}
  • the daemonset created should be the datadog-agent-default daemonset, with one pod on each node. The labels for the daemonset should have provider=default
  • The provider labels for DCA and CCR should be provider=eks

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@swang392 swang392 added this to the v1.23.0 milestone Jan 23, 2026
@swang392 swang392 added the bug Something isn't working label Jan 23, 2026
@swang392 swang392 changed the title [introspection] Fix agent daemonset scheduling for multiple provider node labels [introspection] Fix agent daemonset scheduling on EKS nodes Jan 23, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.03%. Comparing base (0016a60) to head (aeca45b).

Files with missing lines Patch % Lines
...dogagent/feature/controlplanemonitoring/feature.go 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
+ Coverage   37.88%   38.03%   +0.14%     
==========================================
  Files         303      303              
  Lines       26002    26064      +62     
==========================================
+ Hits         9851     9913      +62     
  Misses      15408    15408              
  Partials      743      743              
Flag Coverage Δ
unittests 38.03% <97.05%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...er/datadogagent/controller_reconcile_v2_helpers.go 55.97% <100.00%> (+0.66%) ⬆️
pkg/kubernetes/provider.go 90.32% <100.00%> (+6.11%) ⬆️
...dogagent/feature/controlplanemonitoring/feature.go 13.63% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0016a60...aeca45b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swang392 swang392 marked this pull request as ready for review January 23, 2026 21:56
@swang392 swang392 requested a review from a team as a code owner January 23, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants