-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GPU monitoring #1601
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
+ Coverage 48.94% 48.96% +0.01%
==========================================
Files 227 236 +9
Lines 20636 21315 +679
==========================================
+ Hits 10101 10437 +336
- Misses 10010 10337 +327
- Partials 525 541 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
6777208
to
ce25955
Compare
ce25955
to
60173ad
Compare
60173ad
to
dd0dd9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a minor edit requested
What does this PR do?
This PR adds support for the GPU monitoring feature, doing all the required changes to improve experience of customers.
Motivation
Simplify deployment of GPU monitoring.
Additional Notes
This is an initial implementation of the feature. It does not support deployment of mixed clusters (those where not all nodes have GPUs).
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
feature.gpu.enabled: yes
.runtimeClassName: nvidia
withkubectl get pod datadog-agent-XXX -o json | jq ".spec.runtimeClassName"
.DD_GPU_MONITORING_ENABLED
is set to true in both theagent
andsystem-probe
containers.Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label