[CECO-1153] APM e2e test #1549
[CECO-1153] APM e2e test #1549
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
=======================================
Coverage 48.94% 48.94%
=======================================
Files 227 227
Lines 20636 20636
=======================================
Hits 10101 10101
Misses 10010 10010
Partials 525 525
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
| func verifyAPISpans(s *kindSuite, c *assert.CollectT) { | ||
| // TODO: check uniqueness of kind.ClusterName per test run | ||
| // If not unique, we can also use pod_name to filter spans | ||
| spansQuery := fmt.Sprintf("(env:e2e-operator service:e2e-test-apm* kube_cluster_name:%s)", s.Env().Kind.ClusterName) |
There was a problem hiding this comment.
Cluster name is not unique across separate tests belonging to a test suite
| @@ -367,6 +373,48 @@ func (s *kindSuite) TestKindRun() { | |||
|
|
|||
| }) | |||
|
|
|||
| s.T().Run("APM (hostPort, local service, UDP) works", func(t *testing.T) { | |||
There was a problem hiding this comment.
| s.T().Run("APM (hostPort, local service, UDP) works", func(t *testing.T) { | |
| s.T().Run("APM hostPort, local service, UDP works", func(t *testing.T) { |
Could we remove parentheses in the test names? That way when you run a specific test using make e2e-test we don't have to add double quotes or escape characters to account for the parentheses
What does this PR do?
Introduces an APM e2e test in two parts:
Motivation
What inspired you to submit this pull request?
Additional Notes
Some additional nits:
WithDevModeshould be removed inmainbranch, it should only be used for devMinimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel