Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.3 support #92

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Ruby 3.3 support #92

merged 7 commits into from
Sep 16, 2024

Conversation

wildodecisiv
Copy link
Contributor

@wildodecisiv wildodecisiv commented Sep 16, 2024

What does this PR do?

  • Add suppport for ruby 3.3 generating the layers for amd and arm 64 architecture
  • Remove Gemfile.lock from .gitignore because it causes conflicts adding the local Gemfile.lock to the docker container trying to bundle install dependencies
  • Remove -v from scritps/run_tests.sh to avoid copying all the files from the local to the docker container and have in the container only the files specified in the .dockerignore

Motivation

At my current job we have many lambda functions running using ruby 3.2 and datadog layer, I am migrating to ruby 3.3 because it is available since Apr 2, 2024.

In my team we are waiting this datadog updates for a couple of months but it seems you don't have a bandwith to work on this so far.

#90

Testing Guidelines

  • Using the script run_tests.sh

Additional Notes

Would anyone of the main contributors want to run the integrations tests mentioned in the step 7th of the Contributing guide?

Even having a valid DD_API_KEY I dont want to use my company's api key for running integration tests that can incur in additional charges 😄

BUILD_LAYERS=true DD_API_KEY=<your Datadog api key> ./scripts/run_integration_tests.sh

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@wildodecisiv wildodecisiv requested a review from a team as a code owner September 16, 2024 02:21
@wildodecisiv
Copy link
Contributor Author

@duncanista let me know if I need to do more changes on this pr please :)

@wildodecisiv wildodecisiv mentioned this pull request Sep 16, 2024
@duncanista duncanista self-assigned this Sep 16, 2024
@duncanista
Copy link
Contributor

Everything looks good!

Thanks for this amazing change 🙇🏽
Will merge and start a release as soon as I can!

@duncanista duncanista merged commit 4caef85 into DataDog:main Sep 16, 2024
8 of 10 checks passed
@wildodecisiv
Copy link
Contributor Author

Everything looks good!

Thanks for this amazing change 🙇🏽 Will merge and start a release as soon as I can!

That's great! thanks @duncanista !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants