Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update span pointer imports from the tracer #599

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nhulston
Copy link
Contributor

@nhulston nhulston commented Dec 10, 2024

What does this PR do?

Change the import location of util from the tracer.

Motivation

DataDog/dd-trace-js#4912 moves the location of our util files.

Testing Guidelines

Manually testing

Additional Notes

  • Need to wait for a tracer release and bump the tracer version before the tests here will pass.
  • We haven't yet done a release since the span pointer changes for S3 have been released, so this should not cause any version or failed import errors for our users. Even if it did, import errors are caught and logged

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant