Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aerospike dependency definition #8428

Merged
merged 4 commits into from
Jun 17, 2021
Merged

Remove aerospike dependency definition #8428

merged 4 commits into from
Jun 17, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jun 17, 2021

What does this PR do?

Revert most of #4933

Motivation

No longer necessary since DataDog/integrations-core#8044

@ofek ofek added this to the 7.29.0 milestone Jun 17, 2021
@ofek ofek requested review from a team as code owners June 17, 2021 13:20
Copy link
Contributor

@ogaca-dd ogaca-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should we also remove lines like

?

@ofek
Copy link
Contributor Author

ofek commented Jun 17, 2021

After I update Aerospike to support Python 3.9 I'll try enabling those again

@ofek
Copy link
Contributor Author

ofek commented Jun 17, 2021

(AppVeyor error is unrelated to this change)

@KSerrania
Copy link
Contributor

KSerrania commented Jun 17, 2021

If I understand correctly, in the current state we install the datadog-aerospike integration, but not its dependency aerospike (because of the blacklist_packages.push(/^aerospike==/) lines:

blacklist_packages.push(/^aerospike==/)
,
blacklist_packages.push(/^aerospike==/)
), so we should expect the datadog-aerospike integration from this build to not work OOTB?

@ofek
Copy link
Contributor Author

ofek commented Jun 17, 2021

Ah, I see. Fixed.

@truthbk truthbk merged commit c76d4cb into main Jun 17, 2021
@truthbk truthbk deleted the ofek/aerospike branch June 17, 2021 19:51
@ofek ofek modified the milestones: 7.29.0, 7.30.0 Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants