Skip to content

Conversation

@aiuto
Copy link
Contributor

@aiuto aiuto commented Jan 30, 2026

Fix inclusion of dd-compile-policy to check for linux plain flavor instead of any flavor.

testing

Build .deb before and after, then compare content.

~ $ tree_size_compare.py heroku.before.json Downloads/datadog-heroku-agent_7.77.0~devel.git.184.75ccea9.pipeline.93894712-1_amd64.deb
Loading expected tree: heroku.before.json
Found 21730 items
Comparing against: Downloads/datadog-heroku-agent_7.77.0~devel.git.184.75ccea9.pipeline.93894712-1_amd64.deb

Files/directories in expected but not in got:
  [file] opt/datadog-agent/LICENSES/dd-compile-policy-LICENSE
  [file] opt/datadog-agent/embedded/bin/dd-compile-policy

Size gates are showing a decrease in many files but I believe this is signal noise. If I compare the arm-a7.deb files from the baseline 8039d49 (#45749) to this one, I do not see the size change. Nor is dd_compile_policy missing.

$ tree_size_compare.py --max_allowed_absolute_increase 100  pr45749.json datadog-agent_7.77.0\~devel.git.197.75962ef.pipeline.93951971-1_arm64.deb
Loading expected tree: pr45749.json
Found 22393 items
Comparing against: datadog-agent_7.77.0~devel.git.197.75962ef.pipeline.93951971-1_arm64.deb

Files with size changes exceeding threshold:
  opt/datadog-agent/bin/agent/agent: size increased by 4128 bytes (max allowed: 100)
    expected: 107815688 bytes
    got:      107819816 bytes
  opt/datadog-agent/embedded/bin/system-probe: size increased by 16480 bytes (max allowed: 100)
    expected: 59342512 bytes
    got:      59358992 bytes

@aiuto aiuto added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 30, 2026
@github-actions github-actions bot added team/agent-build short review PR is simple enough to be reviewed quickly labels Jan 30, 2026
@aiuto aiuto marked this pull request as ready for review January 30, 2026 20:05
@aiuto aiuto requested a review from a team as a code owner January 30, 2026 20:05
@aiuto aiuto requested a review from arapulido January 30, 2026 20:05
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 30, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 8039d49
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -47.4 KiB (0.01% reduction) 748.129 → 748.083 → 754.830
agent_heroku_amd64 -912.42 KiB (0.27% reduction) 325.601 → 324.710 → 329.530
agent_rpm_amd64 -47.4 KiB (0.01% reduction) 748.113 → 748.067 → 754.800
agent_rpm_arm64 -48.78 KiB (0.01% reduction) 727.195 → 727.148 → 737.340
agent_suse_amd64 -47.4 KiB (0.01% reduction) 748.113 → 748.067 → 754.800
agent_suse_arm64 -48.78 KiB (0.01% reduction) 727.195 → 727.148 → 737.340
docker_agent_amd64 -47.27 KiB (0.01% reduction) 810.605 → 810.559 → 817.140
docker_agent_arm64 -48.64 KiB (0.01% reduction) 814.282 → 814.234 → 824.020
docker_agent_jmx_amd64 -47.26 KiB (0.00% reduction) 1001.484 → 1001.438 → 1008.020
docker_agent_jmx_arm64 -48.64 KiB (0.00% reduction) 993.880 → 993.832 → 1003.620
21 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64_fips 708.191 MiB
agent_msi 659.750 MiB
agent_rpm_amd64_fips 708.175 MiB
agent_rpm_arm64_fips 689.748 MiB
agent_suse_amd64_fips 708.175 MiB
agent_suse_arm64_fips 689.748 MiB
docker_cluster_agent_amd64 180.824 MiB
docker_cluster_agent_arm64 196.670 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.445 MiB
docker_dogstatsd_arm64 36.812 MiB
dogstatsd_deb_amd64 29.665 MiB
dogstatsd_deb_arm64 27.833 MiB
dogstatsd_rpm_amd64 29.665 MiB
dogstatsd_suse_amd64 29.665 MiB
iot_agent_deb_amd64 42.759 MiB
iot_agent_deb_arm64 39.880 MiB
iot_agent_deb_armhf 40.446 MiB
iot_agent_rpm_amd64 42.759 MiB
iot_agent_suse_amd64 42.759 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +36.55 KiB (0.02% increase) 182.830 → 182.866 → 184.810
agent_deb_amd64_fips +23.45 KiB (0.01% increase) 174.327 → 174.350 → 177.560
agent_heroku_amd64 -104.49 KiB (0.12% reduction) 87.297 → 87.195 → 88.450
agent_msi +16.0 KiB (0.01% increase) 142.430 → 142.445 → 143.300
agent_rpm_amd64 -46.43 KiB (0.02% reduction) 185.809 → 185.764 → 188.160
agent_rpm_amd64_fips +10.99 KiB (0.01% increase) 176.723 → 176.733 → 178.900
agent_rpm_arm64 +12.86 KiB (0.01% increase) 168.390 → 168.402 → 169.930
agent_rpm_arm64_fips +42.98 KiB (0.03% increase) 160.761 → 160.803 → 163.120
agent_suse_amd64 -46.43 KiB (0.02% reduction) 185.809 → 185.764 → 188.160
agent_suse_amd64_fips +10.99 KiB (0.01% increase) 176.723 → 176.733 → 178.900
agent_suse_arm64 +12.86 KiB (0.01% increase) 168.390 → 168.402 → 169.930
agent_suse_arm64_fips +42.98 KiB (0.03% increase) 160.761 → 160.803 → 163.120
docker_agent_amd64 +4.34 KiB (0.00% increase) 275.103 → 275.107 → 277.400
docker_agent_arm64 neutral 262.662 MiB → 266.040
docker_agent_jmx_amd64 +8.94 KiB (0.00% increase) 343.742 → 343.751 → 346.020
docker_agent_jmx_arm64 neutral 327.288 MiB → 330.660
docker_cluster_agent_amd64 neutral 63.871 MiB → 64.510
docker_cluster_agent_arm64 neutral 60.149 MiB → 61.170
docker_cws_instrumentation_amd64 neutral 2.994 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.876 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.216 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.839 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.726 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.849 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.849 MiB → 8.800
iot_agent_deb_amd64 neutral 11.213 MiB → 12.040
iot_agent_deb_arm64 neutral 9.588 MiB → 10.450
iot_agent_deb_armhf neutral 9.783 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.232 MiB → 12.060
iot_agent_suse_amd64 neutral 11.232 MiB → 12.060

@aiuto aiuto marked this pull request as draft January 31, 2026 02:15
@aiuto
Copy link
Contributor Author

aiuto commented Jan 31, 2026

The unexpected size reduction may mean it is overdeleting.
But it might be because of the wrong baseline. I want to check again

@aiuto aiuto marked this pull request as ready for review January 31, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants