Skip to content

Conversation

@dd-octo-sts
Copy link
Contributor

@dd-octo-sts dd-octo-sts bot commented Jan 30, 2026

Backport 3937bbf from #45686.


What does this PR do?

This PR removes PID reuse detection logic which resulted in way too many false positives. The root cause was, the EVP stream doesn't have the same clock timestamp as procfs data, making PID reuse detection with this method impossible.

Bryce had commented on this originally, noting that the rest of the agent doesn't currently catch this scenario, in retrospect I should have deleted this code back then.

Motivation

Improve resolv.conf detection rate.

Describe how you validated your changes

The buggy code no longer exists. TestDNSWorkload should continue to pass.

…does this PR do? This PR removes PID reuse detection logic which resulted in way too many false positives. The root cause was, the EVP stream doesn't have the same clock timestamp as procfs data, making PID reuse detection with this method impossible.

Bryce had [commented on this](#43099 (comment)) originally, noting that the rest of the agent doesn't currently catch this scenario, in retrospect I should have deleted this code back then.

### Motivation
Improve resolv.conf detection rate.

### Describe how you validated your changes
The buggy code no longer exists. TestDNSWorkload should continue to pass.

Co-authored-by: stuart.geipel <[email protected]>
(cherry picked from commit 3937bbf)

___

Co-authored-by: Stuart Geipel <[email protected]>
@dd-octo-sts dd-octo-sts bot requested a review from a team as a code owner January 30, 2026 01:33
@dd-octo-sts dd-octo-sts bot requested review from Janaeq and removed request for a team January 30, 2026 01:33
@dd-octo-sts dd-octo-sts bot added backport bot changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/cloud-network-monitoring labels Jan 30, 2026
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 30, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 0b30861
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64_fips -4.0 KiB (0.00% reduction) 702.008 → 702.004 → 704.000
agent_rpm_amd64_fips -4.0 KiB (0.00% reduction) 701.991 → 701.987 → 703.990
agent_suse_amd64_fips -4.0 KiB (0.00% reduction) 701.991 → 701.987 → 703.990
28 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 753.343 MiB
agent_heroku_amd64 326.785 MiB
agent_msi 663.083 MiB
agent_rpm_amd64 753.326 MiB
agent_rpm_arm64 732.086 MiB
agent_rpm_arm64_fips 684.078 MiB
agent_suse_amd64 753.326 MiB
agent_suse_arm64 732.086 MiB
agent_suse_arm64_fips 684.078 MiB
docker_agent_amd64 815.450 MiB
docker_agent_arm64 818.797 MiB
docker_agent_jmx_amd64 1006.329 MiB
docker_agent_jmx_arm64 998.395 MiB
docker_cluster_agent_amd64 181.095 MiB
docker_cluster_agent_arm64 196.921 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.859 MiB
docker_dogstatsd_arm64 37.128 MiB
dogstatsd_deb_amd64 30.074 MiB
dogstatsd_deb_arm64 28.219 MiB
dogstatsd_rpm_amd64 30.074 MiB
dogstatsd_suse_amd64 30.074 MiB
iot_agent_deb_amd64 43.033 MiB
iot_agent_deb_arm64 40.135 MiB
iot_agent_deb_armhf 40.705 MiB
iot_agent_rpm_amd64 43.034 MiB
iot_agent_suse_amd64 43.034 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -29.86 KiB (0.02% reduction) 183.977 → 183.947 → 184.810
agent_deb_amd64_fips +23.46 KiB (0.01% increase) 172.688 → 172.711 → 173.790
agent_heroku_amd64 -3.24 KiB (0.00% reduction) 87.153 → 87.150 → 88.450
agent_msi -8.0 KiB (0.01% reduction) 143.160 → 143.152 → 143.300
agent_rpm_amd64 -16.57 KiB (0.01% reduction) 186.873 → 186.857 → 188.160
agent_rpm_amd64_fips -16.42 KiB (0.01% reduction) 175.719 → 175.703 → 176.600
agent_rpm_arm64 +18.23 KiB (0.01% increase) 168.630 → 168.648 → 169.930
agent_rpm_arm64_fips +19.33 KiB (0.01% increase) 159.197 → 159.216 → 160.550
agent_suse_amd64 -16.57 KiB (0.01% reduction) 186.873 → 186.857 → 188.160
agent_suse_amd64_fips -16.42 KiB (0.01% reduction) 175.719 → 175.703 → 176.600
agent_suse_arm64 +18.23 KiB (0.01% increase) 168.630 → 168.648 → 169.930
agent_suse_arm64_fips +19.33 KiB (0.01% increase) 159.197 → 159.216 → 160.550
docker_agent_amd64 -2.72 KiB (0.00% reduction) 276.711 → 276.709 → 277.400
docker_agent_arm64 -2.04 KiB (0.00% reduction) 264.161 → 264.159 → 266.040
docker_agent_jmx_amd64 -2.95 KiB (0.00% reduction) 345.356 → 345.353 → 346.020
docker_agent_jmx_arm64 +4.93 KiB (0.00% increase) 328.779 → 328.784 → 330.660
docker_cluster_agent_amd64 neutral 63.983 MiB → 64.490
docker_cluster_agent_arm64 neutral 60.245 MiB → 61.170
docker_cws_instrumentation_amd64 neutral 2.994 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.037 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.362 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.949 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.829 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.960 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.960 MiB → 8.800
iot_agent_deb_amd64 neutral 11.293 MiB → 12.040
iot_agent_deb_arm64 neutral 9.654 MiB → 10.450
iot_agent_deb_armhf neutral 9.850 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.308 MiB → 12.060
iot_agent_suse_amd64 neutral 11.308 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Jan 30, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8ba1244d-5eed-4635-90c6-eefa045838b9

Baseline: 0b30861
Comparison: d535a2d
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.94 [-1.11, +4.99] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.94 [-1.11, +4.99] 1 Logs
quality_gate_metrics_logs memory utilization +0.42 [+0.20, +0.63] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.39 [+0.18, +0.59] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.34 [+0.17, +0.50] 1 Logs
ddot_metrics_sum_delta memory utilization +0.29 [+0.08, +0.50] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.17 [+0.12, +0.23] 1 Logs
file_tree memory utilization +0.06 [+0.01, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.44, +0.55] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.02 [-0.11, +0.14] 1 Logs
quality_gate_idle memory utilization +0.01 [-0.03, +0.06] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.04, +0.05] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.10, +0.08] 1 Logs
ddot_logs memory utilization -0.02 [-0.08, +0.05] 1 Logs
docker_containers_memory memory utilization -0.02 [-0.10, +0.06] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.43, +0.39] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.42, +0.36] 1 Logs
otlp_ingest_metrics memory utilization -0.14 [-0.29, +0.01] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.22 [-0.45, +0.01] 1 Logs
otlp_ingest_logs memory utilization -0.23 [-0.33, -0.13] 1 Logs
quality_gate_idle_all_features memory utilization -0.27 [-0.31, -0.23] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.96 [-1.03, -0.89] 1 Logs
quality_gate_logs % cpu utilization -1.49 [-2.99, +0.02] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@avonengel
Copy link
Contributor

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 30, 2026

View all feedbacks in Devflow UI.

2026-01-30 06:25:27 UTC ℹ️ Start processing command /merge


2026-01-30 06:25:32 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in 7.76.x is approximately 49m (p90).


2026-01-30 06:49:20 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 838a9b5 into 7.76.x Jan 30, 2026
482 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the backport-45686-to-7.76.x branch January 30, 2026 06:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
@github-actions github-actions bot added this to the 7.76.0 milestone Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant