-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[TEEP-4568] [AGENT-15468] fix(python): restore check_name tag on datadog.agent.check_ready #45715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Fixed regression introduced on 7.73 where check_name was not being returned on datadog.agent.check_ready
python: add release note for check_ready check_name tag fix
Static quality checks✅ Please find below the results from static quality gates 31 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 681899c Optimization Goals: ✅ Improvement(s) detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -2.68 | [-5.68, +0.32] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ✅ | tcp_syslog_to_blackhole | ingress throughput | +37.22 | [+37.11, +37.34] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.00 | [-0.13, +0.13] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.15, +0.12] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.35 | [-0.51, -0.19] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.52 | [-0.75, -0.29] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.63 | [-0.67, -0.59] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.65 | [-1.04, -0.27] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.66 | [-1.16, -0.16] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.67 | [-1.06, -0.27] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -1.14 | [-1.25, -1.03] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -1.21 | [-1.44, -0.99] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -1.31 | [-1.51, -1.12] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -1.72 | [-1.79, -1.65] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -2.10 | [-2.14, -2.06] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | -2.10 | [-2.22, -1.98] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -2.55 | [-2.60, -2.51] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -2.68 | [-5.68, +0.32] | 1 | Logs |
| ➖ | file_tree | memory utilization | -2.76 | [-2.81, -2.71] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -2.79 | [-2.84, -2.73] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -2.99 | [-3.19, -2.78] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | -3.14 | [-3.29, -2.99] | 1 | Logs |
| ✅ | quality_gate_logs | % cpu utilization | -50.33 | [-51.68, -48.98] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
|
Manual QA: Agent v7.72 was OK Agent v7.73 regression introduced FIX |
What changed
Fixes a regression where
datadog.agent.check_readywas emitted without acheck_nametag value.Ensures the name used for
reportPy3Warnings()is the successfully loaded module name, with a fallback toconfig.Name.Why
reportPy3Warnings()to be empty in some cases, resulting in missingcheck_nametag values and collapsing linted-state tracking.How
Track the successfully loaded module name (
loadedName) at theget_class(...)success point.Use
loadedNamewhen callingreportPy3Warnings().Fallback to
config.NameifloadedNameis unexpectedly empty.Testing / QA plan
Repro on an affected Agent build where
datadog.agent.check_readyis present but lackscheck_name.Run Agent with a Python check that triggers the
reportPy3Warnings()path.Verify in Metrics Explorer that
datadog.agent.check_readyincludescheck_name:<expected>.