Skip to content

Conversation

@brycekahle
Copy link
Member

What does this PR do?

Adds macOS (darwin) to list of platforms for system-probe

Motivation

PRs will report changes to macOS Go dependencies

Describe how you validated your changes

Additional Notes

@brycekahle brycekahle requested a review from a team as a code owner January 27, 2026 22:55
@brycekahle brycekahle added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation ask-review Ask required teams to review this PR labels Jan 27, 2026
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-runtimes labels Jan 27, 2026
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 73bca2a
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Change Size (prev → curr → max)
docker_cluster_agent_amd64 +6.74 KiB (0.00% increase) 181.170 → 181.177 → 181.200
30 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 752.287 MiB
agent_deb_amd64_fips 700.968 MiB
agent_heroku_amd64 326.610 MiB
agent_msi 662.875 MiB
agent_rpm_amd64 752.271 MiB
agent_rpm_amd64_fips 700.952 MiB
agent_rpm_arm64 731.023 MiB
agent_rpm_arm64_fips 683.074 MiB
agent_suse_amd64 752.271 MiB
agent_suse_amd64_fips 700.952 MiB
agent_suse_arm64 731.023 MiB
agent_suse_arm64_fips 683.074 MiB
docker_agent_amd64 814.409 MiB
docker_agent_arm64 817.794 MiB
docker_agent_jmx_amd64 1005.287 MiB
docker_agent_jmx_arm64 997.392 MiB
docker_cluster_agent_arm64 196.983 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.816 MiB
docker_dogstatsd_arm64 37.127 MiB
dogstatsd_deb_amd64 30.035 MiB
dogstatsd_deb_arm64 28.184 MiB
dogstatsd_rpm_amd64 30.035 MiB
dogstatsd_suse_amd64 30.035 MiB
iot_agent_deb_amd64 43.013 MiB
iot_agent_deb_arm64 40.119 MiB
iot_agent_deb_armhf 40.689 MiB
iot_agent_rpm_amd64 43.014 MiB
iot_agent_suse_amd64 43.014 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +8.73 KiB (0.00% increase) 183.823 → 183.832 → 184.810
agent_deb_amd64_fips +19.2 KiB (0.01% increase) 172.575 → 172.594 → 173.790
agent_heroku_amd64 -2.52 KiB (0.00% reduction) 87.122 → 87.120 → 88.450
agent_msi +16.0 KiB (0.01% increase) 143.094 → 143.109 → 143.300
agent_rpm_amd64 +18.9 KiB (0.01% increase) 186.836 → 186.855 → 188.160
agent_rpm_amd64_fips +76.77 KiB (0.04% increase) 175.595 → 175.670 → 176.600
agent_rpm_arm64 +46.19 KiB (0.03% increase) 168.453 → 168.498 → 169.930
agent_rpm_arm64_fips neutral 159.079 MiB → 160.550
agent_suse_amd64 +18.9 KiB (0.01% increase) 186.836 → 186.855 → 188.160
agent_suse_amd64_fips +76.77 KiB (0.04% increase) 175.595 → 175.670 → 176.600
agent_suse_arm64 +46.19 KiB (0.03% increase) 168.453 → 168.498 → 169.930
agent_suse_arm64_fips neutral 159.079 MiB → 160.550
docker_agent_amd64 +2.84 KiB (0.00% increase) 276.532 → 276.535 → 277.400
docker_agent_arm64 neutral 263.946 MiB → 266.040
docker_agent_jmx_amd64 neutral 345.167 MiB → 346.020
docker_agent_jmx_arm64 neutral 328.567 MiB → 330.660
docker_cluster_agent_amd64 neutral 64.003 MiB → 64.510
docker_cluster_agent_arm64 neutral 60.268 MiB → 61.170
docker_cws_instrumentation_amd64 neutral 2.994 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.023 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.350 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.938 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.822 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.951 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.951 MiB → 8.800
iot_agent_deb_amd64 neutral 11.286 MiB → 12.040
iot_agent_deb_arm64 +2.94 KiB (0.03% increase) 9.646 → 9.649 → 10.450
iot_agent_deb_armhf neutral 9.840 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.304 MiB → 12.060
iot_agent_suse_amd64 neutral 11.304 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8b40e426-fb89-4feb-954e-9147f1a9c54c

Baseline: dfd77ae
Comparison: af39abe
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.43 [-0.68, +5.55] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.43 [-0.68, +5.55] 1 Logs
quality_gate_metrics_logs memory utilization +1.53 [+1.31, +1.75] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization +0.70 [+0.54, +0.85] 1 Logs
ddot_logs memory utilization +0.65 [+0.57, +0.73] 1 Logs
file_tree memory utilization +0.60 [+0.54, +0.65] 1 Logs
otlp_ingest_logs memory utilization +0.55 [+0.45, +0.66] 1 Logs
ddot_metrics memory utilization +0.53 [+0.30, +0.75] 1 Logs
docker_containers_memory memory utilization +0.39 [+0.31, +0.47] 1 Logs
ddot_metrics_sum_delta memory utilization +0.20 [-0.01, +0.42] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.11 [-0.12, +0.34] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.02 [-0.03, +0.08] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.13, +0.12] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.11, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.05, +0.04] 1 Logs
quality_gate_idle_all_features memory utilization -0.01 [-0.05, +0.03] 1 Logs bounds checks dashboard
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.10, +0.08] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.43, +0.41] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.41, +0.37] 1 Logs
quality_gate_idle memory utilization -0.06 [-0.10, -0.01] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization -0.11 [-0.27, +0.05] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.14 [-0.67, +0.40] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.93 [-0.99, -0.86] 1 Logs
quality_gate_logs % cpu utilization -2.42 [-3.89, -0.94] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@brycekahle
Copy link
Member Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 28, 2026

View all feedbacks in Devflow UI.

2026-01-28 00:02:25 UTC ℹ️ Start processing command /merge


2026-01-28 00:02:32 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-28 00:36:17 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-01-28 02:50:35 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit aca3356 into main Jan 28, 2026
309 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the bryce.kahle/sysprobe-macos-deps branch January 28, 2026 02:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
@github-actions github-actions bot added this to the 7.77.0 milestone Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ask-review Ask required teams to review this PR changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants