Skip to content

Conversation

@aiuto
Copy link
Contributor

@aiuto aiuto commented Jan 27, 2026

ABLD-280 Replace freetds omnibus script

@aiuto aiuto added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 27, 2026
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-integrations team/agent-build labels Jan 27, 2026
@aiuto aiuto force-pushed the aiuto/freetds branch 2 times, most recently from e929b1f to c0ef780 Compare January 27, 2026 19:45
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 27, 2026
@aiuto aiuto force-pushed the aiuto/freetds branch 4 times, most recently from 469667b to 8f46434 Compare January 28, 2026 04:52
@aiuto aiuto requested a review from JSGette January 28, 2026 05:26
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 28, 2026

Static quality checks

❌ Please find below the results from static quality gates
Comparison made with ancestor bac181f
📊 Static Quality Gates Dashboard

Error

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 (on wire) +3.41 MiB (1.85% increase) 183.842 → 187.248 → 184.810
agent_deb_amd64 (on disk) +11.16 MiB (1.48% increase) 752.128 → 763.288 → 754.830
agent_deb_amd64_fips (on wire) +3.27 MiB (1.90% increase) 172.568 → 175.841 → 173.790
agent_deb_amd64_fips (on disk) +11.16 MiB (1.59% increase) 700.805 → 711.965 → 704.000
agent_rpm_amd64 (on wire) +2.28 MiB (1.22% increase) 186.932 → 189.208 → 188.160
agent_rpm_amd64 (on disk) +11.16 MiB (1.48% increase) 752.111 → 763.272 → 754.800
agent_rpm_amd64_fips (on wire) +1.77 MiB (1.01% increase) 175.635 → 177.404 → 176.600
agent_rpm_amd64_fips (on disk) +11.16 MiB (1.59% increase) 700.789 → 711.949 → 703.990
agent_rpm_arm64 (on wire) +3.57 MiB (2.12% increase) 168.468 → 172.035 → 169.930
agent_rpm_arm64 (on disk) +10.16 MiB (1.39% increase) 730.855 → 741.017 → 737.340
agent_rpm_arm64_fips (on wire) +3.17 MiB (1.99% increase) 159.099 → 162.266 → 160.550
agent_rpm_arm64_fips (on disk) +10.16 MiB (1.49% increase) 682.918 → 693.079 → 688.480
agent_suse_amd64 (on wire) +2.28 MiB (1.22% increase) 186.932 → 189.208 → 188.160
agent_suse_amd64 (on disk) +11.16 MiB (1.48% increase) 752.111 → 763.272 → 754.800
agent_suse_amd64_fips (on wire) +1.77 MiB (1.01% increase) 175.635 → 177.404 → 176.600
agent_suse_amd64_fips (on disk) +11.16 MiB (1.59% increase) 700.789 → 711.949 → 703.990
agent_suse_arm64 (on wire) +3.57 MiB (2.12% increase) 168.468 → 172.035 → 169.930
agent_suse_arm64 (on disk) +10.16 MiB (1.39% increase) 730.855 → 741.017 → 737.340
agent_suse_arm64_fips (on wire) +3.17 MiB (1.99% increase) 159.099 → 162.266 → 160.550
agent_suse_arm64_fips (on disk) +10.16 MiB (1.49% increase) 682.918 → 693.079 → 688.480
docker_agent_amd64 (on wire) +3.96 MiB (1.43% increase) 276.541 → 280.503 → 277.400
docker_agent_amd64 (on disk) +11.16 MiB (1.37% increase) 814.255 → 825.416 → 817.140
docker_agent_arm64 (on wire) +4.6 MiB (1.74% increase) 263.940 → 268.540 → 266.040
docker_agent_arm64 (on disk) +10.16 MiB (1.24% increase) 817.629 → 827.790 → 824.020
docker_agent_jmx_amd64 (on wire) +3.97 MiB (1.15% increase) 345.173 → 349.140 → 346.020
docker_agent_jmx_amd64 (on disk) +11.16 MiB (1.11% increase) 1005.134 → 1016.294 → 1008.020
docker_agent_jmx_arm64 (on wire) +4.6 MiB (1.40% increase) 328.555 → 333.158 → 330.660
docker_agent_jmx_arm64 (on disk) +10.16 MiB (1.02% increase) 997.227 → 1007.388 → 1003.620
Gate failure full details
Quality gate Error type Error message
agent_deb_amd64 StaticQualityGateFailed �[91mstatic_quality_gate_agent_deb_amd64 failed!
Wire size 187.2 MB exceeds limit of 184.8 MB by 2.4 MB
Disk size 763.3 MB exceeds limit of 754.8 MB by 8.5 MB�[0m
agent_deb_amd64_fips StaticQualityGateFailed �[91mstatic_quality_gate_agent_deb_amd64_fips failed!
Wire size 175.8 MB exceeds limit of 173.8 MB by 2.1 MB
Disk size 712.0 MB exceeds limit of 704.0 MB by 8.0 MB�[0m
agent_rpm_amd64 StaticQualityGateFailed �[91mstatic_quality_gate_agent_rpm_amd64 failed!
Wire size 189.2 MB exceeds limit of 188.2 MB by 1.0 MB
Disk size 763.3 MB exceeds limit of 754.8 MB by 8.5 MB�[0m
agent_rpm_amd64_fips StaticQualityGateFailed �[91mstatic_quality_gate_agent_rpm_amd64_fips failed!
Wire size 177.4 MB exceeds limit of 176.6 MB by 823.5 KB
Disk size 711.9 MB exceeds limit of 704.0 MB by 8.0 MB�[0m
agent_rpm_arm64 StaticQualityGateFailed �[91mstatic_quality_gate_agent_rpm_arm64 failed!
Wire size 172.0 MB exceeds limit of 169.9 MB by 2.1 MB
Disk size 741.0 MB exceeds limit of 737.3 MB by 3.7 MB�[0m
agent_rpm_arm64_fips StaticQualityGateFailed �[91mstatic_quality_gate_agent_rpm_arm64_fips failed!
Wire size 162.3 MB exceeds limit of 160.5 MB by 1.7 MB
Disk size 693.1 MB exceeds limit of 688.5 MB by 4.6 MB�[0m
agent_suse_amd64 StaticQualityGateFailed �[91mstatic_quality_gate_agent_suse_amd64 failed!
Wire size 189.2 MB exceeds limit of 188.2 MB by 1.0 MB
Disk size 763.3 MB exceeds limit of 754.8 MB by 8.5 MB�[0m
agent_suse_amd64_fips StaticQualityGateFailed �[91mstatic_quality_gate_agent_suse_amd64_fips failed!
Wire size 177.4 MB exceeds limit of 176.6 MB by 823.5 KB
Disk size 711.9 MB exceeds limit of 704.0 MB by 8.0 MB�[0m
agent_suse_arm64 StaticQualityGateFailed �[91mstatic_quality_gate_agent_suse_arm64 failed!
Wire size 172.0 MB exceeds limit of 169.9 MB by 2.1 MB
Disk size 741.0 MB exceeds limit of 737.3 MB by 3.7 MB�[0m
agent_suse_arm64_fips StaticQualityGateFailed �[91mstatic_quality_gate_agent_suse_arm64_fips failed!
Wire size 162.3 MB exceeds limit of 160.5 MB by 1.7 MB
Disk size 693.1 MB exceeds limit of 688.5 MB by 4.6 MB�[0m
docker_agent_amd64 StaticQualityGateFailed �[91mstatic_quality_gate_docker_agent_amd64 failed!
Wire size 280.5 MB exceeds limit of 277.4 MB by 3.1 MB
Disk size 825.4 MB exceeds limit of 817.1 MB by 8.3 MB�[0m
docker_agent_arm64 StaticQualityGateFailed �[91mstatic_quality_gate_docker_agent_arm64 failed!
Wire size 268.5 MB exceeds limit of 266.0 MB by 2.5 MB
Disk size 827.8 MB exceeds limit of 824.0 MB by 3.8 MB�[0m
docker_agent_jmx_amd64 StaticQualityGateFailed �[91mstatic_quality_gate_docker_agent_jmx_amd64 failed!
Wire size 349.1 MB exceeds limit of 346.0 MB by 3.1 MB
Disk size 1016.3 MB exceeds limit of 1008.0 MB by 8.3 MB�[0m
docker_agent_jmx_arm64 StaticQualityGateFailed �[91mstatic_quality_gate_docker_agent_jmx_arm64 failed!
Wire size 333.2 MB exceeds limit of 330.7 MB by 2.5 MB
Disk size 1007.4 MB exceeds limit of 1003.6 MB by 3.8 MB�[0m

Static quality gates prevent the PR to merge!
You can check the static quality gates confluence page for guidance. We also have a toolbox page available to list tools useful to debug the size increase.

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_heroku_amd64 -23.37 KiB (0.01% reduction) 326.418 → 326.395 → 329.530
16 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_msi 662.890 MiB
docker_cluster_agent_amd64 181.177 MiB
docker_cluster_agent_arm64 196.983 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.819 MiB
docker_dogstatsd_arm64 37.127 MiB
dogstatsd_deb_amd64 30.035 MiB
dogstatsd_deb_arm64 28.184 MiB
dogstatsd_rpm_amd64 30.035 MiB
dogstatsd_suse_amd64 30.035 MiB
iot_agent_deb_amd64 43.013 MiB
iot_agent_deb_arm64 40.119 MiB
iot_agent_deb_armhf 40.689 MiB
iot_agent_rpm_amd64 43.014 MiB
iot_agent_suse_amd64 43.014 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +3.41 MiB (1.85% increase) 183.842 → 187.248 → 184.810
agent_deb_amd64_fips +3.27 MiB (1.90% increase) 172.568 → 175.841 → 173.790
agent_rpm_amd64 +2.28 MiB (1.22% increase) 186.932 → 189.208 → 188.160
agent_rpm_amd64_fips +1.77 MiB (1.01% increase) 175.635 → 177.404 → 176.600
agent_rpm_arm64 +3.57 MiB (2.12% increase) 168.468 → 172.035 → 169.930
agent_rpm_arm64_fips +3.17 MiB (1.99% increase) 159.099 → 162.266 → 160.550
agent_suse_amd64 +2.28 MiB (1.22% increase) 186.932 → 189.208 → 188.160
agent_suse_amd64_fips +1.77 MiB (1.01% increase) 175.635 → 177.404 → 176.600
agent_suse_arm64 +3.57 MiB (2.12% increase) 168.468 → 172.035 → 169.930
agent_suse_arm64_fips +3.17 MiB (1.99% increase) 159.099 → 162.266 → 160.550
docker_agent_amd64 +3.96 MiB (1.43% increase) 276.541 → 280.503 → 277.400
docker_agent_arm64 +4.6 MiB (1.74% increase) 263.940 → 268.540 → 266.040
docker_agent_jmx_amd64 +3.97 MiB (1.15% increase) 345.173 → 349.140 → 346.020
docker_agent_jmx_arm64 +4.6 MiB (1.40% increase) 328.555 → 333.158 → 330.660
agent_heroku_amd64 +4.77 KiB (0.01% increase) 87.185 → 87.190 → 88.450
agent_msi -4.0 KiB (0.00% reduction) 143.121 → 143.117 → 143.300
docker_cluster_agent_amd64 neutral 64.002 MiB → 64.510
docker_cluster_agent_arm64 neutral 60.271 MiB → 61.170
docker_cws_instrumentation_amd64 neutral 2.994 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.024 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.346 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.938 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.822 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.950 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.950 MiB → 8.800
iot_agent_deb_amd64 neutral 11.288 MiB → 12.040
iot_agent_deb_arm64 -2.01 KiB (0.02% reduction) 9.646 → 9.644 → 10.450
iot_agent_deb_armhf neutral 9.842 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.304 MiB → 12.060
iot_agent_suse_amd64 neutral 11.304 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Jan 28, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d01c8161-79aa-4e73-bf9b-895d6c4275a9

Baseline: bac181f
Comparison: 05d57b4
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -4.76 [-7.73, -1.79] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +0.81 [-0.72, +2.34] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.48 [+0.27, +0.69] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.27 [+0.22, +0.32] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.17 [+0.01, +0.33] 1 Logs
quality_gate_idle_all_features memory utilization +0.12 [+0.09, +0.16] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.09 [-0.02, +0.21] 1 Logs
quality_gate_idle memory utilization +0.09 [+0.05, +0.13] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.37, +0.46] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.50, +0.53] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.02 [-0.08, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.00 [-0.38, +0.39] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.12, +0.12] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.03 [-0.16, +0.10] 1 Logs
file_tree memory utilization -0.04 [-0.09, +0.02] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.09, -0.00] 1 Logs
docker_containers_memory memory utilization -0.18 [-0.25, -0.11] 1 Logs
ddot_logs memory utilization -0.32 [-0.39, -0.25] 1 Logs
ddot_metrics memory utilization -0.45 [-0.65, -0.24] 1 Logs
otlp_ingest_metrics memory utilization -0.68 [-0.84, -0.53] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.69 [-0.92, -0.46] 1 Logs
quality_gate_metrics_logs memory utilization -0.86 [-1.07, -0.65] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.09 [-1.19, -1.00] 1 Logs
docker_containers_cpu % cpu utilization -4.76 [-7.73, -1.79] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

# If you depend on this, you must also depend on ":imported_ssl_headers".
cc_import(
name = "ssl",
# hrs seems to have no effect in practice, but we have it here because
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth filing a bug to rules_cc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. But then I would have to spend the time to provide a minimal reproduction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure I'm not holding it wrong.

@aiuto aiuto marked this pull request as ready for review January 28, 2026 18:30
@aiuto aiuto requested review from a team as code owners January 28, 2026 18:30

filegroup(
name = "all_srcs",
name = "all_src",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost plural?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored to all_srcs.

@aiuto aiuto force-pushed the aiuto/freetds branch 2 times, most recently from 0238647 to ceb2b01 Compare January 29, 2026 04:28
- Enable the work from pr/45289
- Fold this up to the parent step to eliminate another node in the graph.
- Adjust librpm and libxmlsec to account for new ssl shared library targets.

But yuck....

To turn the output of rules_foreign_cc into something useable we have
to create a lot of scaffolding. It's an ugly change to the openssl BUILD.
If we have to do this a lot, we should fix rules_foreign_cc to hide the
complexity. It would require significant new API on their part.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants