Skip to content

Conversation

@pgimalac
Copy link
Member

What does this PR do?

Remove the seelog dependency in the agent binaries and tests

Motivation

We don't use / need it anymore, it will reduce binary size, remove an unmaintained dependency, and enable simplifying code

Describe how you validated your changes

CI

Additional Notes

@pgimalac pgimalac requested review from a team as code owners January 27, 2026 16:25
@pgimalac pgimalac added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-runtimes labels Jan 27, 2026
@pgimalac pgimalac requested a review from Enzu83 January 27, 2026 16:25
@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Jan 27, 2026
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 27, 2026

Go Package Import Differences

Baseline: 6cc4493
Comparison: 369e627

binaryosarchchange
agentlinuxamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
agentlinuxarm64
+0, -2
-github.com/cihub/seelog
-net/smtp
agentwindowsamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
agentdarwinamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
agentdarwinarm64
+0, -2
-github.com/cihub/seelog
-net/smtp
iot-agentlinuxamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
iot-agentlinuxarm64
+0, -2
-github.com/cihub/seelog
-net/smtp
heroku-agentlinuxamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
cluster-agentlinuxamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
cluster-agentlinuxarm64
+0, -2
-github.com/cihub/seelog
-net/smtp
cluster-agent-cloudfoundrylinuxamd64
+0, -3
-encoding/xml
-github.com/cihub/seelog
-net/smtp
cluster-agent-cloudfoundrylinuxarm64
+0, -3
-encoding/xml
-github.com/cihub/seelog
-net/smtp
dogstatsdlinuxamd64
+0, -4
-archive/zip
-encoding/xml
-github.com/cihub/seelog
-net/smtp
dogstatsdlinuxarm64
+0, -4
-archive/zip
-encoding/xml
-github.com/cihub/seelog
-net/smtp
process-agentlinuxamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
process-agentlinuxarm64
+0, -2
-github.com/cihub/seelog
-net/smtp
process-agentwindowsamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
process-agentdarwinamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
process-agentdarwinarm64
+0, -2
-github.com/cihub/seelog
-net/smtp
heroku-process-agentlinuxamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
security-agentlinuxamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
security-agentlinuxarm64
+0, -2
-github.com/cihub/seelog
-net/smtp
security-agentwindowsamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
sbomgenlinuxamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
sbomgenlinuxarm64
+0, -2
-github.com/cihub/seelog
-net/smtp
system-probelinuxamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
system-probelinuxarm64
+0, -2
-github.com/cihub/seelog
-net/smtp
system-probewindowsamd64
+0, -2
-github.com/cihub/seelog
-net/smtp
system-probedarwinamd64
+0, -3
-archive/zip
-github.com/cihub/seelog
-net/smtp
system-probedarwinarm64
+0, -3
-archive/zip
-github.com/cihub/seelog
-net/smtp
trace-agentlinuxamd64
+0, -4
-archive/zip
-encoding/xml
-github.com/cihub/seelog
-net/smtp
trace-agentlinuxarm64
+0, -4
-archive/zip
-encoding/xml
-github.com/cihub/seelog
-net/smtp
trace-agentwindowsamd64
+0, -4
-archive/zip
-encoding/xml
-github.com/cihub/seelog
-net/smtp
trace-agentdarwinamd64
+0, -3
-archive/zip
-github.com/cihub/seelog
-net/smtp
trace-agentdarwinarm64
+0, -3
-archive/zip
-github.com/cihub/seelog
-net/smtp
heroku-trace-agentlinuxamd64
+0, -4
-archive/zip
-encoding/xml
-github.com/cihub/seelog
-net/smtp
loaderlinuxamd64
+0, -4
-archive/zip
-encoding/xml
-github.com/cihub/seelog
-net/smtp
loaderlinuxarm64
+0, -4
-archive/zip
-encoding/xml
-github.com/cihub/seelog
-net/smtp
loaderdarwinamd64
+0, -4
-archive/zip
-encoding/xml
-github.com/cihub/seelog
-net/smtp
loaderdarwinarm64
+0, -4
-archive/zip
-encoding/xml
-github.com/cihub/seelog
-net/smtp
installerlinuxamd64
+0, -3
-archive/zip
-github.com/cihub/seelog
-net/smtp
installerlinuxarm64
+0, -3
-archive/zip
-github.com/cihub/seelog
-net/smtp
installerwindowsamd64
+0, -3
-archive/zip
-github.com/cihub/seelog
-net/smtp

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 27, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6cc4493
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -3.96 MiB (0.53% reduction) 752.128 → 748.171 → 754.830
agent_deb_amd64_fips -3.84 MiB (0.55% reduction) 700.805 → 696.966 → 704.000
agent_heroku_amd64 -704.25 KiB (0.21% reduction) 326.418 → 325.730 → 329.530
agent_msi -3.07 MiB (0.46% reduction) 662.890 → 659.816 → 1072.620
agent_rpm_amd64 -3.96 MiB (0.53% reduction) 752.111 → 748.155 → 754.800
agent_rpm_amd64_fips -3.84 MiB (0.55% reduction) 700.789 → 696.950 → 703.990
agent_rpm_arm64 -3.59 MiB (0.49% reduction) 730.855 → 727.266 → 737.340
agent_rpm_arm64_fips -3.5 MiB (0.51% reduction) 682.918 → 679.415 → 688.480
agent_suse_amd64 -3.96 MiB (0.53% reduction) 752.111 → 748.155 → 754.800
agent_suse_amd64_fips -3.84 MiB (0.55% reduction) 700.789 → 696.950 → 703.990
agent_suse_arm64 -3.59 MiB (0.49% reduction) 730.855 → 727.266 → 737.340
agent_suse_arm64_fips -3.5 MiB (0.51% reduction) 682.918 → 679.415 → 688.480
docker_agent_amd64 -3.6 MiB (0.44% reduction) 814.255 → 810.652 → 817.140
docker_agent_arm64 -3.28 MiB (0.40% reduction) 817.629 → 814.354 → 824.020
docker_agent_jmx_amd64 -3.6 MiB (0.36% reduction) 1005.134 → 1001.530 → 1008.020
docker_agent_jmx_arm64 -3.28 MiB (0.33% reduction) 997.227 → 993.952 → 1003.620
docker_cluster_agent_amd64 -341.16 KiB (0.18% reduction) 181.177 → 180.844 → 181.200
docker_cluster_agent_arm64 -321.19 KiB (0.16% reduction) 196.983 → 196.670 → 198.490
docker_dogstatsd_amd64 -415.34 KiB (1.04% reduction) 38.819 → 38.414 → 39.380
docker_dogstatsd_arm64 -387.28 KiB (1.02% reduction) 37.127 → 36.749 → 37.940
dogstatsd_deb_amd64 -415.31 KiB (1.35% reduction) 30.035 → 29.630 → 30.610
dogstatsd_deb_arm64 -391.28 KiB (1.36% reduction) 28.184 → 27.802 → 29.110
dogstatsd_rpm_amd64 -415.31 KiB (1.35% reduction) 30.035 → 29.630 → 30.610
dogstatsd_suse_amd64 -415.31 KiB (1.35% reduction) 30.035 → 29.630 → 30.610
iot_agent_deb_amd64 -276.91 KiB (0.63% reduction) 43.013 → 42.743 → 43.290
iot_agent_deb_arm64 -264.84 KiB (0.64% reduction) 40.119 → 39.860 → 40.920
iot_agent_deb_armhf -264.52 KiB (0.63% reduction) 40.689 → 40.431 → 41.030
iot_agent_rpm_amd64 -276.91 KiB (0.63% reduction) 43.014 → 42.743 → 43.290
iot_agent_suse_amd64 -276.91 KiB (0.63% reduction) 43.014 → 42.743 → 43.290
2 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -1.04 MiB (0.57% reduction) 183.877 → 182.837 → 184.810
agent_deb_amd64_fips -1.32 MiB (0.76% reduction) 172.634 → 171.318 → 173.790
agent_heroku_amd64 +74.27 KiB (0.08% increase) 87.181 → 87.254 → 88.450
agent_msi -712.0 KiB (0.49% reduction) 143.129 → 142.434 → 143.300
agent_rpm_amd64 -1.08 MiB (0.58% reduction) 186.932 → 185.853 → 188.160
agent_rpm_amd64_fips -1.98 MiB (1.13% reduction) 175.597 → 173.620 → 176.600
agent_rpm_arm64 -50.67 KiB (0.03% reduction) 168.446 → 168.397 → 169.930
agent_rpm_arm64_fips -103.37 KiB (0.06% reduction) 159.073 → 158.972 → 160.550
agent_suse_amd64 -1.08 MiB (0.58% reduction) 186.932 → 185.853 → 188.160
agent_suse_amd64_fips -1.98 MiB (1.13% reduction) 175.597 → 173.620 → 176.600
agent_suse_arm64 -50.67 KiB (0.03% reduction) 168.446 → 168.397 → 169.930
agent_suse_arm64_fips -103.37 KiB (0.06% reduction) 159.073 → 158.972 → 160.550
docker_agent_amd64 -1.43 MiB (0.52% reduction) 276.549 → 275.116 → 277.400
docker_agent_arm64 -1.26 MiB (0.48% reduction) 263.958 → 262.703 → 266.040
docker_agent_jmx_amd64 -1.43 MiB (0.41% reduction) 345.175 → 343.749 → 346.020
docker_agent_jmx_arm64 -1.25 MiB (0.38% reduction) 328.576 → 327.325 → 330.660
docker_cluster_agent_amd64 -132.82 KiB (0.20% reduction) 64.002 → 63.873 → 64.510
docker_cluster_agent_arm64 -116.86 KiB (0.19% reduction) 60.271 → 60.157 → 61.170
docker_cws_instrumentation_amd64 neutral 2.994 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 -165.77 KiB (1.08% reduction) 15.024 → 14.862 → 15.820
docker_dogstatsd_arm64 -150.94 KiB (1.03% reduction) 14.346 → 14.198 → 14.830
dogstatsd_deb_amd64 -108.39 KiB (1.33% reduction) 7.937 → 7.831 → 8.790
dogstatsd_deb_arm64 -107.82 KiB (1.54% reduction) 6.822 → 6.716 → 7.710
dogstatsd_rpm_amd64 -110.77 KiB (1.36% reduction) 7.950 → 7.842 → 8.800
dogstatsd_suse_amd64 -110.77 KiB (1.36% reduction) 7.950 → 7.842 → 8.800
iot_agent_deb_amd64 -77.86 KiB (0.67% reduction) 11.286 → 11.210 → 12.040
iot_agent_deb_arm64 -63.98 KiB (0.65% reduction) 9.647 → 9.585 → 10.450
iot_agent_deb_armhf -65.55 KiB (0.65% reduction) 9.842 → 9.778 → 10.620
iot_agent_rpm_amd64 -78.26 KiB (0.68% reduction) 11.304 → 11.228 → 12.060
iot_agent_suse_amd64 -78.26 KiB (0.68% reduction) 11.304 → 11.228 → 12.060

@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Jan 27, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f340ec18-0b70-4cd4-9673-3e3347403f32

Baseline: 3203c5b
Comparison: 369e627
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.06 [-1.09, +5.21] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.06 [-1.09, +5.21] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.78 [+1.69, +1.87] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.50 [+0.34, +0.65] 1 Logs
quality_gate_metrics_logs memory utilization +0.44 [+0.23, +0.66] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.12 [+0.04, +0.19] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.08 [+0.04, +0.12] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.32, +0.44] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.05 [-0.37, +0.46] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.12, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.10, +0.09] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.11] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.04 [-0.28, +0.19] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.06 [-0.57, +0.45] 1 Logs
quality_gate_idle_all_features memory utilization -0.18 [-0.22, -0.15] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.37 [-0.53, -0.22] 1 Logs
file_tree memory utilization -0.45 [-0.50, -0.40] 1 Logs
docker_containers_memory memory utilization -0.50 [-0.58, -0.43] 1 Logs
otlp_ingest_logs memory utilization -0.54 [-0.65, -0.44] 1 Logs
ddot_metrics_sum_delta memory utilization -0.56 [-0.75, -0.38] 1 Logs
quality_gate_logs % cpu utilization -0.91 [-2.41, +0.59] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.92 [-1.14, -0.70] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -1.09 [-1.15, -1.04] 1 Logs
quality_gate_idle memory utilization -1.27 [-1.31, -1.23] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@pgimalac
Copy link
Member Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 28, 2026

View all feedbacks in Devflow UI.

2026-01-28 14:03:10 UTC ℹ️ Start processing command /merge


2026-01-28 14:03:23 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-28 18:03:31 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@pgimalac
Copy link
Member Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 28, 2026

View all feedbacks in Devflow UI.

2026-01-28 18:13:19 UTC ℹ️ Start processing command /merge


2026-01-28 18:13:38 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-28 18:43:04 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 2h (p90).


2026-01-28 19:21:42 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 3b361ec into main Jan 28, 2026
510 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the pgimalac/remove-seelog-entirely branch January 28, 2026 19:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
@github-actions github-actions bot added this to the 7.77.0 milestone Jan 28, 2026
@rdesgroppes
Copy link
Contributor

Great, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants